New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy for FreeCAD Contribution Process (FCP) #7638
Conversation
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A person who merges patches
Before git: "diffs" and "patches".
Now: "pull request"
Co-authored-by: Ajinkya Dahale <AjinkyaDahale@users.noreply.github.com>
remove redefinition of 'user'
Change 'patch' to 'contribution'
Revise the policy for contributors to be included in the "About" dialog
Clarify 5.6 Change 2.4 to redirect users to forum for help/general discussion Change 1.2 to strike 'useful'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job! This is a very good text IMHO
Typo 1.1 Remove explicit time frame in 6.11.1 change capitalization in 6.11.2 "Primary Developer" is intentionally not defined. Remove unnecessary "User" 6.11.17
split 5.1
The document is pretty tight now. contributions and reviews have slowed. I've removed the draft status but will continue to accept suggestions. And we can always revise it going forward. |
Updating 8.1 policy for inviting maintainers
Merged. Thanks to all! |
ironically, this PR was merged in violation of the policy, the commits should have been squashed |
fixes #7633
App
,Base
,Gui
or one of theMod
subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master
./bin/FreeCAD --run-test 0
Fixes typo in Draft Move command text
Draft: Fixed typos
issue #<id>
orfixes #<id>
where<id>
is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex:Draft: fix typos - fixes #4805
And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.