Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain .FCStd files in source code are licensed "All Rights Reserved" #8894

Open
2 of 5 tasks
dpward opened this issue Mar 15, 2023 · 27 comments · Fixed by #9794
Open
2 of 5 tasks

Certain .FCStd files in source code are licensed "All Rights Reserved" #8894

dpward opened this issue Mar 15, 2023 · 27 comments · Fixed by #9794
Assignees
Labels
WB FEM Related to the FEM Workbench

Comments

@dpward
Copy link

dpward commented Mar 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Forums discussion

https://forum.freecad.org/viewtopic.php?t=76603

Version

0.21 (Development)

Full version info

Not applicable

Subproject(s) affected?

None

Issue description

.FCStd files contain embedded licensing information. The FreeCAD source code itself includes .FCStd files, and many of these are (most likely inadvertently) marked with the license "All Rights Reserved".

This license is incompatible with the FreeCAD project (see Licensing, Ownership, and Credit in the FreeCAD Contribution Process). This is also incompatible with requirements for inclusion in distributions such as Debian or Fedora.

Anything else?

Affected files include:

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz luzpaz added WB FEM Related to the FEM Workbench WB CAM Related to the CAM/Path Workbench labels Mar 15, 2023
@LarryWoestman
Copy link
Contributor

I have a pull request #8899 that should change the licensing for boxtest1.fcstd and drill_test1.FCStd to Creative Commons 4.0.
If you prefer to change the licensing some other way, that is fine with me.

Russ4262 added a commit to Russ4262/FreeCAD that referenced this issue Mar 16, 2023
Addresses user-specific need in FreeCAD#8894
Russ4262 added a commit to Russ4262/FreeCAD that referenced this issue Mar 16, 2023
Addresses user-specific need in FreeCAD#8894
@Russ4262 Russ4262 mentioned this issue Mar 16, 2023
1 task
donovaly pushed a commit that referenced this issue Mar 16, 2023
Addresses user-specific need in #8894
@donovaly
Copy link
Member

I updated the initial info since 3 files have now been updated. I propose to update the list on every further change.

@sliptonic
Copy link
Member

#8916 fixes the files where I'm original creator

@sliptonic
Copy link
Member

#9010 Fixes all files authored by mlampert. (Discussed with him via email)

@donovaly
Copy link
Member

#9010 Fixes all files authored by mlampert. (Discussed with him via email)

Thanks.
What is with?:
src/Mod/Path/PathTests/Tools/Shape/test-path-tool-bit-shape-00.fcstd

kpemartin pushed a commit to kpemartin/FreeCAD that referenced this issue Mar 26, 2023
Addresses user-specific need in FreeCAD#8894
@dpward
Copy link
Author

dpward commented Apr 24, 2023

So what about the remaining files here? Is there another way to contact the authors? Should they be removed from the project?

Note that @PrzemoF responded on the forum regarding box.FCStd (renamed from cube.fcstd).

@sliptonic
Copy link
Member

I'll fix the other Path file. That was an oversight. Already approved by mlampert

sliptonic added a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 24, 2023
@sliptonic
Copy link
Member

I'm removing the Path label since all Path files have been addressed.

@sliptonic sliptonic removed the WB CAM Related to the CAM/Path Workbench label Apr 26, 2023
chennes pushed a commit to chennes/FreeCAD that referenced this issue Apr 27, 2023
chennes pushed a commit to chennes/FreeCAD that referenced this issue Apr 27, 2023
@dpward
Copy link
Author

dpward commented Jun 5, 2023

Note that @PrzemoF responded on the forum regarding box.FCStd (renamed from cube.fcstd).

I think this comment was missed...

@chennes
Copy link
Member

chennes commented Jun 5, 2023

So that will take care of the top one on the list, leaving just the last two. There's probably no path to revising the license on those (we haven't heard from their authors in some time). I don't really know anything about the FEM test suite. @berndhahnebach any problem with removing those two cases?

@berndhahnebach
Copy link
Contributor

berndhahnebach commented Jun 22, 2023

The PR was merged ... :-( Have there more files been removed out of FEM? What do we need to do to get them back. AFAIK all fcstd can be generated by FreeCAD and Python, thus we can recreate them and add the correct license.

@berndhahnebach
Copy link
Contributor

I would like to get them back into FreeCAD.

@chennes
Copy link
Member

chennes commented Jun 22, 2023

That would be great -- I don't know what was involved with the development of those files so I couldn't do it. If you can regenerate with the correct license I'm happy to get that merged in.

@berndhahnebach
Copy link
Contributor

berndhahnebach commented Jun 22, 2023

let us start with the python files. What is wrong with them? ... #9794 (comment)

@chennes
Copy link
Member

chennes commented Jun 22, 2023

Nothing -- it was just the FCStd files, but to be clean about it I removed the entire test case that relied on those files. If you can replace the files, we can just re-add everything else back in.

@dpward
Copy link
Author

dpward commented Jun 22, 2023

@berndhahnebach The authors who originally created the files put "All Rights Reserved" as the license. No one has been able to contact them to see if they actually want to re-license their contribution under something else. It's not about an issue changing the file - we would be violating their copyright.

@berndhahnebach
Copy link
Contributor

Mhh clean would be just to use the python and recreate the FCStd ... but anyway ...

  1. I will go for a PR to readd all Python since they do not violate any licesnce.

  2. I will recreate the FCStd. This might take a few days because I would need to check if everything works out well.

Would this be OK?

@berndhahnebach
Copy link
Contributor

BTW. No author created the FCStd files. They where created in FreeCAD by python and even saved by Python. Might be "All Rights Reserved" is what FreeCAD does write on standard? How do I controll this?

@dpward
Copy link
Author

dpward commented Jun 22, 2023

If you are editing the FCStd files in FreeCAD itself: https://wiki.freecad.org/Licence

You can set the owner of the file and specify your own license terms for the files you produce inside FreeCAD, via menu File → Project Information.

@berndhahnebach
Copy link
Contributor

I am the Python guy. All these FCStd fils have been fully automatically created by Python. Thus the question. How do I edit these licence information by Python?

Unbenannt

@dpward
Copy link
Author

dpward commented Jun 22, 2023

If you want to change it in FreeCAD after Python generates it: set the "license information" drop-down to something else there, e.g. CC-BY-SA-4.0. But how to do that programmatically I don't know...

@berndhahnebach
Copy link
Contributor

If you want to change it in FreeCAD after Python generates it: set the "license information" drop-down to something else there, e.g. CC-BY-SA-4.0.

this is not available in drop down list for me

@FlachyJoe
Copy link
Contributor

@berndhahnebach You can set whatever you want for this property
App.ActiveDocument.License = "Do what you want with this!"

@berndhahnebach
Copy link
Contributor

found it ...

>>> App.ActiveDocument.License
'All rights reserved'
>>> 
>>> App.ActiveDocument.License = "My fancy licence"
>>> 
>>> App.ActiveDocument.License
'My fancy licence'
>>> 

@berndhahnebach
Copy link
Contributor

berndhahnebach commented Jun 22, 2023

upps double post ... or cross post or how ever it is named if two people post the same at the same time

@dpward
Copy link
Author

dpward commented Jun 22, 2023

If you want to change it in FreeCAD after Python generates it: set the "license information" drop-down to something else there, e.g. CC-BY-SA-4.0.

this is not available in drop down list for me

Not sure which version of FreeCAD you're running, but as a result of this whole thread, the license options that can be selected in the GUI were updated: see 898403a

@berndhahnebach
Copy link
Contributor

ahh ok, ATM I am not on my dev machine. On the working machine I do have not the newes FreeCAD installed. But I have all information needed to make a PR. Thanks ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB FEM Related to the FEM Workbench
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants