Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Notifications are below the main window of FreeCAD #8940

Closed
2 tasks done
donovaly opened this issue Mar 18, 2023 · 3 comments
Closed
2 tasks done

[Core] Notifications are below the main window of FreeCAD #8940

donovaly opened this issue Mar 18, 2023 · 3 comments
Labels
Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD

Comments

@donovaly
Copy link
Member

donovaly commented Mar 18, 2023 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Forums discussion

https://forum.freecad.org/viewtopic.php?p=668153#p668153

Version

0.21

Full version info

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.21.0.32357 (Git)
Build type: Release
Branch: master
Hash: d23b576c3361b7d593b8e65255a5f970e5954c39
Python 3.8.10, Qt 5.15.2, Coin 4.0.1, Vtk 8.2.0, OCC 7.6.3
Locale: English/United States (en_US) [ OS: German/Germany (de_DE) ]

Subproject(s) affected?

Core

Issue description

The message notification feature shows messages always below FreeCAD's main window.

Here is a screencast of a selection mistake. The error message appears below the main window:
5YaSOFhAF0

Anything else?

@abdullahtahiriyo

Code of Conduct

  • I agree to follow this project's Code of Conduct
@donovaly
Copy link
Member Author

@abdullahtahiriyo

@donovaly donovaly changed the title [Issue] [Core] Notifictations are below the main window of FreeCAD Mar 18, 2023
@donovaly donovaly changed the title [Core] Notifictations are below the main window of FreeCAD [Core] Notifications are below the main window of FreeCAD Mar 18, 2023
@luzpaz luzpaz added Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD labels Mar 18, 2023
@abdullahtahiriyo
Copy link
Contributor

I see.

In my PC this renders inside the frame. I will look into it.

abdullahtahiriyo added a commit to abdullahtahiriyo/FreeCAD_sf_master that referenced this issue Mar 19, 2023
@abdullahtahiriyo
NotificationBox/NotificationArea: Restrict rendering area to main frame
ca183d0 
========================================================================

The NotificationBox is extended to take the QRect in global coordinates. Then
it will try to dimension the label within this area. If a fixed width is provided, that
is enforced (take precedence).

The NotificationArea passes the QRect of the main window to the NotificationBox.

This is intended to fix:
FreeCAD#8940
@abdullahtahiriyo abdullahtahiriyo mentioned this issue Mar 19, 2023
Merged
@donovaly
Copy link
Member Author

Will be fixed with #8958

chennes pushed a commit to chennes/FreeCAD that referenced this issue Mar 23, 2023
@abdullahtahiriyo @chennes
NotificationBox/NotificationArea: Restrict rendering area to main frame
0c75ec2 
========================================================================

The NotificationBox is extended to take the QRect in global coordinates. Then
it will try to dimension the label within this area. If a fixed width is provided, that
is enforced (take precedence).

The NotificationArea passes the QRect of the main window to the NotificationBox.

This is intended to fix:
FreeCAD#8940
kpemartin pushed a commit to kpemartin/FreeCAD that referenced this issue Mar 26, 2023
@abdullahtahiriyo @kpemartin
NotificationBox/NotificationArea: Restrict rendering area to main frame
1b002e1 
========================================================================

The NotificationBox is extended to take the QRect in global coordinates. Then
it will try to dimension the label within this area. If a fixed width is provided, that
is enforced (take precedence).

The NotificationArea passes the QRect of the main window to the NotificationBox.

This is intended to fix:
FreeCAD#8940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@donovaly @luzpaz @abdullahtahiriyo