FEM: removing "constraint" from the names

[kaktusus]

Removing "constraint" from the names of most FEM workbench features.
#10217

[chennes]

@FEA-eng I believe you are the local expert in this area -- would you mind reviewing?

[FEA-eng]

@FEA-eng I believe you are the local expert in this area -- would you mind reviewing?

I checked this and discussed with @kaktusus. Everything is fine, this PR can be merged.

[chennes]

FYI @kaktusus, I fixed up your branch a bit: I used an interactive rebase (git rebase -i) to "drop" all but the single commit you actually wanted to keep, and then I rebased onto the latest HEAD of the master branch. That's what I've force-pushed here.

[maxwxyz]

@kaktusus @FEA-eng Nice to see this change, unfortunately when creating the "constraints", the tree items still keep the name with "constraint":

[code]
OS: Windows 11 build 22631
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.34873 (Git)
Build type: Release
Branch: main
Hash: 889c8c49f1bbc0910c8dc32a512f4c6fbedeb8b9
Python 3.10.13, Qt 5.15.8, Coin 4.0.0, Vtk 9.2.5, OCC 7.6.3
Locale: German/Germany (de_DE)
Installed mods: 
  * 3DfindIT 1.2.0
  * 3D_Printing_Tools
  * BIM 2021.12.0
  * CfdOF 1.24.7
  * CurvedShapes 1.0.4
  * Curves 0.6.14
  * Defeaturing 1.2.1
  * fasteners 0.4.68
  * freecad.gears 1.0.0
  * freecad_metal_workbench 0.0.1
  * OpenDark 2023.10.30
  * sheetmetal 0.3.1
  * Silk 0.1.5
[/code]

[kaktusus]

This problem coincides with an open ticket ...
was recently raised I think by you luzpaz (or by chennes)
can't find it now ...
will try to look for it again later 😉

[kaktusus]

it took me a while but I found it: #5547
so that we can link this post to that thread.

[maxwxyz]

Not sure if #5547 is about the same. I thought in this PR here, the idea was to remove the prefix "constraint" in FEM. When adding the "constraints" the tree elements still have the name "constraint" in them, shouldn't they be removed in the tree items as well, to match the button names?

[FEA-eng]

@maxwxyz I created a new issue to try to resolve it: #11298

[kaktusus]

Not sure if #5547 is about the same. I thought in this PR here, the idea was to remove the prefix "constraint" in FEM. When adding the "constraints" the tree elements still have the name "constraint" in them, shouldn't they be removed in the tree items as well, to match the button names?

These are related topics for me I noticed another problem.

On the other hand, you are definitely right about the mainstream. 😉