Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar View and Structure cleaning #10761

Merged
merged 8 commits into from Sep 25, 2023

Conversation

PaddleStroke
Copy link
Contributor

@PaddleStroke PaddleStroke commented Sep 20, 2023

This PR does several things :

  • Put Link in the command group

  • Give Link a proper tooltip (screenshot outdated: tooltips changed).
    image

  • Put sel_back and sel_forward in the treeview actions group rather than in root of view toolbar. This way they now appear in the view menu (they weren't before) and they don't appear in the root of view toolbar.

  • Give them proper names and tooltips (screenshot outdated: tooltips changed)
    image

  • Remove 'Link Navigation' from the view toolbar

  • Put 'Link Navigation' in the view menu where it was missing.

  • Remove 'Bouding box' from the view toolbar (its still in view menu)

  • Reorder the view toolbar so that the order makes sense.

image

Lastly it improves the tooltips of std_part and std_group.

Fixes #10755
Fixes #10756
Fixes #10757
Fixes #10758

…here they belong.

This also solve the fact that these commands were not in the menu which are supposed to be exaustive.
Remove "Std_LinkSelectActions" from the toolbar.
Remove "Std_SelBack" & "Std_SelForward" from the toolbar
Remove "Std_SelBoundingBox"
 from the toolbar
Reorder the toolbar entries.
@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Sep 20, 2023
src/Gui/CommandLink.cpp Outdated Show resolved Hide resolved
@Roy-043
Copy link
Contributor

Roy-043 commented Sep 20, 2023

The texts for the new tooltips seem to be directly copied from the Wiki. This does not necessarily work well. Some consitency with the other tooltips in the same menu/toolbar may also be desirable. I also think that a tooltip should be relatively short.

Example:

Wiki text (and current tooltip proposal):
"The Std SelBack command restores the previous recorded Tree view selection. Note that selections are only recorded if Tree RecordSelection mode is switched on."

Shorter alternative:
"Restore the previous Tree view selection. Only works if Tree RecordSelection mode is switched on."

@PaddleStroke
Copy link
Contributor Author

I don't think tooltips need to be particularly short.
Having said that you are right in your example that the command name is not necessary.

@Roy-043
Copy link
Contributor

Roy-043 commented Sep 20, 2023

My suggestion for the other tooltips (fixing some language issues and shortening a few):

A Link is an object that references or links to another object in the same document, or in another document. Unlike Clones, Links reference the original Shape directly, making them more memory efficient which helps with the creation of complex assemblies.

A Part is a general purpose container to keep together a group of objects so that they act as a unit in the 3D view. It is meant to arrange objects that have a Part TopoShape, like Part Primitives, PartDesign Bodies, and other Parts."

A Group is a general purpose container to group objects in the Tree view, regardless of their data type. It is a simple folder to organize the objects in a model.

@PaddleStroke
Copy link
Contributor Author

Sounds good to me. I updated them.

@mwganson
Copy link
Contributor

I prefer having the selection arrows on the toolbar. Is there a preference to keep them there?

@qewer33
Copy link
Contributor

qewer33 commented Sep 21, 2023

I prefer having the selection arrows on the toolbar. Is there a preference to keep them there?

You can customize the toolbars from Tools > Customize and you can even create custom toolbars for functions that you use regularly.

@PaddleStroke
Copy link
Contributor Author

PaddleStroke commented Sep 21, 2023

I have not added a preference to keep them in as :

  • custom toolbar let you do this very easily.
  • no one of the forum (https://forum.freecad.org/viewtopic.php?t=81319) seem to even know what these were doing.
    So it feels like very few people actually use them. IMO custom toolbars are specifically designed for such niche tools.

@adrianinsaval
Copy link
Member

I have not added a preference to keep them in as :

* custom toolbar let you do this very easily.

* no one of the forum (https://forum.freecad.org/viewtopic.php?t=81319) seem to even know what these were doing.
  So it feels like very few people actually use them. IMO custom toolbars are specifically designed for such niche tools.

Yes, let's not keep polluting FreeCAD with very niche config options that serve no real purpose than a minor convenience for a small subset of users.

@chennes chennes merged commit 8945ab6 into FreeCAD:master Sep 25, 2023
7 checks passed
@wwmayer
Copy link
Contributor

wwmayer commented Sep 26, 2023

After each start of FreeCAD these error messages appear in the console:

<Command> Command.cpp(1828): duplicate command Std_SelBack
<Command> Command.cpp(1828): duplicate command Std_SelForward

The extra creation of StdCmdSelBack and StdCmdSelForward should be removed from CreateViewStdCommands()

@PaddleStroke
Copy link
Contributor Author

Ah yes sorry about this. I will fix it asap.

@wwmayer
Copy link
Contributor

wwmayer commented Sep 26, 2023

I have a PR: #10819

@sliptonic sliptonic deleted the ui_view_toolbar branch October 9, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
7 participants