Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark and Light stylesheets fixes/improvements #112

Merged
merged 1 commit into from Mar 7, 2016
Merged

Dark and Light stylesheets fixes/improvements #112

merged 1 commit into from Mar 7, 2016

Conversation

pgilfernandez
Copy link
Contributor

  • fixed background logo for Win and Linux
  • improved QToolBar handle for different icon sizes (selectable by user inside Preferences)
  • tweaked editable fields inside QToolBar in order to work for all icon sizes (selectable by user inside Preferences)
  • fixed Ubuntu problem that caused a blank line inside up/down buttons of QSpinBox and similar
  • tweaked Python Editor color for Light theme
  • fixed buttons margin/padding inside Task tab
  • tweaked color for checked QPushButtons inside Draft WB for better user experience

+ fixed background logo for Win and Linux
+ improved QToolBar handle for different icon sizes (selectable by user inside Preferences)
+ tweaked editable fields inside QToolBar in order to work for all icon sizes (selectable by user inside Preferences)
+ fixed Ubuntu problem that caused a blank line inside up/down buttons of QSpinBox and similar
+ tweaked Python Editor color for Light theme
+ fixed buttons margin/padding inside Task tab
+ tweaked color for checked QPushButtons inside Draft WB for better user experience
@pgilfernandez
Copy link
Contributor Author

They still lack of the CMake file that I don't know how to create and correctly set...

Thanks

wwmayer added a commit that referenced this pull request Mar 7, 2016
Dark and Light stylesheets fixes/improvements
@wwmayer wwmayer merged commit 9fa224a into FreeCAD:master Mar 7, 2016
@wwmayer
Copy link
Contributor

wwmayer commented Mar 7, 2016

Two things to mention:

  1. Under Linux there is a problem with the spaces in the qss file names. So, I renamed them.
  2. When using any of the style sheets you don't get a visual feedback when the mouse hovers over a tool button or if you click on it.

@pgilfernandez
Copy link
Contributor Author

  1. no problem, I understand it's much better without spaces
  2. you are right, it was a design decision based on OSX default theme that behaves the same. I have tried Ubuntu and Windows and they do have this visual feedback so maybe you are right and it's better to include hover and pressed styles over toolbar buttons. I will add them in next update that probably will fix any other issue that is found over this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants