New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gui: Consolidate PythonWrapper #12088
Conversation
I'm about to tear out QtWebEngineWidgets, so don't worry too much about that one 😄. |
@chennes, that was really fast, so I'm not worried any more. I would appreciate is someone could look at Addon Manager part. I works now, it is a bit ungly. |
These AddonManager changes should be fine, all of those methods and constants existed in Qt 5.12. |
25582fc
to
d21e753
Compare
The problem with Addon Manager is that I do not know where that float comes from. It ends this way:
So that typecasing to int is needed, alhough documentation says it should be u64. And I do not like pushing things I do not understand. @wwmayer, could you elaborate why is QPrinter special? (see XXX in the code) |
Ah, |
Addon Manager has its PR #12100 now. However I do not know how to remove label. |
This is looking good now -- is it ready for review? |
Yes, however only shiboken/PySide access via C++ is working while via Python it still does not. This is the same as before. Of course, I would appreciate help with debugging. Just uncomment block mentioned in code, to see the problem FreeCAD/src/Gui/PythonWrapper.cpp Line 37 in 02c6a90
|
So here it is: I bet someone more familiar with codebase would find it way sooner (or perhaps I should try setting up a decent debugger) |
508db86
to
51e40a1
Compare
a77d320
to
9321166
Compare
SetupShibokenAndPyside macro checks module include path and eventually decides to disable respective module in case its include directory is missing. Make this process more straightforward by testing directory existence; "Location: " string is 10 not 9 characters long and leading whitespace makes testing for directory name fail. While there, rename variables to respect that find_pip_package returns only single include and library path.
This is just a draft as I'm unable to verify all configurations.
I'm still unhappy with PythonWrapper, there are way too many ifdeffed paths, making it error prone. An attempt to clean it up a bit is made. Disclaimer: a week ago I had zero knowledge about Shiboken and it does improve very slowly over time.
Issues:
Comments very welcome and appreciated.