[PD] Accept a unique face as wire provider if no subShape is selected (fix #12084) #12102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The issue also mentions PartDesign_ShapeBinder (and edge) and PartDesign_SubShapeBinder edge as rejected profiles, does this PR also fix that? |
|
@Roy-043 if the Binder (or SubShapeBinder) has ONE face you can select whatever you want, the face will be used. |
|
I have understood the code properly then. What if the (sub)shapebinder does not have a face but only a closed wire. Those objects can be used for a Pad operation. It seems relevant to also fix that. |
|
Replaced by #12207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the selected object has only one face then accept it as a Profile.
Fix [Problem] Profile criteria for Helix and Revolution features are inconsistent #12084