Core: Create a SuppressibleExtension to provide the Suppressed property to all the WBs #12412

FlachyJoe · 2024-02-14T22:08:17Z

Many objects can be suppressed, this extension aims to provide a unique visualization in the tree view.

FlachyJoe · 2024-02-15T18:06:07Z

@wwmayer could you please take a look? ViewProviderSuppressibleExtension::extensionUpdateData is never called.

EDIT: Ok, done. I spent an hour for search and I found when I asked for help 🙄

FlachyJoe · 2024-02-15T21:48:43Z

FlachyJoe · 2024-02-16T11:04:18Z

Ready for review.
I have no possibility to debug MacOS nor Windows build, it certainly lacks one new file's mention in a config.

FlachyJoe · 2024-02-17T08:14:39Z

Back to draft: a crash occurs at object deletion.

FlachyJoe · 2024-02-17T10:43:42Z

Got it. I was confused by

>>> doc=App.ActiveDocument
>>> doc.Body.addExtension('App::SuppressibleExtension')
Traceback (most recent call last):
  File "<input>", line 1, in <module>
TypeError: Extension is not a python addable version: 'App::SuppressibleExtension'

But using App::SuppressibleExtensionPython is ok

>>> doc.Body.addExtension('App::SuppressibleExtensionPython')
>>> doc.Body.ViewObject.addExtension('Gui::ViewProviderSuppressibleExtensionPython')
>>>

wwmayer · 2024-02-17T11:18:04Z

In how far is this related to #5545?
Original ticket in Mantis: https://tracker.freecad.org/view.php?id=402
Forum thread: https://forum.freecad.org/viewtopic.php?t=1070

FlachyJoe · 2024-02-17T14:24:09Z

@wwmayer I don't think a Suppressed object aims to be a Emancipated one (cut from parents).

FlachyJoe · 2024-02-21T15:26:55Z

I've added a Suppress/Unsuppress action in the tree context menu. This action is only shown if the Suppressed property of the object is not hidden so the action visibility is managed at workbench level.
See https://github.com/FlachyJoe/FreeCAD/blob/7b90aea42915c87eaa643c96fe0758b17727a1e6/src/Mod/PartDesign/App/Feature.cpp#L63

    App::SuppressibleExtension::initExtension(this);
    Suppressed.setStatus(App::Property::Status::Hidden, true); //Todo: remove when TNP fixed

PaddleStroke · 2024-02-27T11:37:11Z

Master does not build (Windows/libpack/visual studio) today. Coming from this PR.

Severity Code Description Project File Line Suppression State
Error C2027 use of undefined type 'Gui::Document' FreeCADGui C:\Users\Sky_l\Desktop\Freecad-Src\src\Gui\ViewProviderSuppressibleExtension.cpp 59
Error C2039 'ActionFunction': is not a member of 'Gui' FreeCADGui C:\Users\Sky_l\Desktop\Freecad-Src\src\Gui\ViewProviderSuppressibleExtension.cpp 110
Error C2065 'ActionFunction': undeclared identifier FreeCADGui C:\Users\Sky_l\Desktop\Freecad-Src\src\Gui\ViewProviderSuppressibleExtension.cpp 110
Error C2065 'func': undeclared identifier FreeCADGui C:\Users\Sky_l\Desktop\Freecad-Src\src\Gui\ViewProviderSuppressibleExtension.cpp 110
Error C2039 'ActionFunction': is not a member of 'Gui' FreeCADGui C:\Users\Sky_l\Desktop\Freecad-Src\src\Gui\ViewProviderSuppressibleExtension.cpp 110
Error C2061 syntax error: identifier 'ActionFunction' FreeCADGui C:\Users\Sky_l\Desktop\Freecad-Src\src\Gui\ViewProviderSuppressibleExtension.cpp 110
Error C2065 'func': undeclared identifier FreeCADGui C:\Users\Sky_l\Desktop\Freecad-Src\src\Gui\ViewProviderSuppressibleExtension.cpp 117
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderPrimitive.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderMirror.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderPython.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderBoolean.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderRuledSurface.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderImport.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderExtrusion.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderScale.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProvider2DObject.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderRegularPolygon.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderTorusParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderCurveNet.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderSpline.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderSphereParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderCylinderParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderConeParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderPrism.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderPointParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderEllipseParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderHelixParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderPlaneParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderBox.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderCompound.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderCircleParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderLineParametric.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\CrossSections.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProvider.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderExt.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) PartGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Part\Gui\ViewProviderReference.obj 1
Error LNK1120 1 unresolved externals PartGui C:\Users\Sky_l\Desktop\FC build\Mod\Part\PartGui.pyd 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) SketcherGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Sketcher\Gui\ViewProviderSketch.obj 1
Error LNK2001 unresolved external symbol "public: virtual bool __cdecl Gui::ViewProvider::acceptReorderingObjects(void)const " (?acceptReorderingObjects@ViewProvider@Gui@@UEBA_NXZ) SketcherGui C:\Users\Sky_l\Desktop\FC build\src\Mod\Sketcher\Gui\ViewProviderPython.obj 1

PaddleStroke · 2024-02-27T12:36:31Z

src/Gui/ViewProviderSuppressibleExtension.h

+namespace Gui
+{
+
+class ViewProviderSuppressibleExtension : public Gui::ViewProviderExtension


This line should be :
class GuiExport ViewProviderSuppressibleExtension : public ViewProviderExtension

PaddleStroke · 2024-02-27T12:40:25Z

src/Gui/ViewProviderSuppressibleExtension.h

+#include "ViewProviderExtensionPython.h"
+
+
+namespace Gui


The namespace should not start here. This line should be
using namespace Gui;

PaddleStroke · 2024-02-27T12:40:52Z

src/Gui/ViewProviderSuppressibleExtension.h

+private:
+    bool isSetSuppressedIcon{false};
+};
+


namespace Gui should start here. See ViewProviderGroupExtension as example

PaddleStroke · 2024-02-27T12:42:44Z

src/Gui/ViewProviderSuppressibleExtension.cpp

+#include "ActionFunction.h"
+#include "Control.h"
+#include "Document.h"
+#include "PreCompiled.h"


"PreCompiled.h" must be the first...
Building now

FlachyJoe · 2024-02-29T20:17:10Z

Thank you @PaddleStroke for the fix.
Isn't the CI supposed to fail before the merge?

PaddleStroke · 2024-03-01T08:25:04Z

The CI is not using the precompiled headers. This is something that is being discussed with @adrianinsaval and @chennes if I recall correctly

FEA-eng · 2024-03-05T11:23:05Z

@FlachyJoe Is it still in development ? I can't find the Suppress option in Properties or in the tree context menu in Part Design.

OS: Windows 10 build 19045
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.36277 (Git)
Build type: Release
Branch: main
Hash: 9e1903d46112b3660bf10c6a4537d728101d560b
Python 3.10.13, Qt 5.15.8, Coin 4.0.2, Vtk 9.2.6, OCC 7.6.3
Locale: Polish/Poland (pl_PL)

FlachyJoe · 2024-03-05T14:23:43Z

@FEA-eng in PD the Suppress property is hidden (right-click, show all) until the TNP fix is merged due to the problems it can produce in shapes hierarchy.

github-actions bot added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB Part Design Related to the Part Design Workbench labels Feb 14, 2024

FlachyJoe mentioned this pull request Feb 14, 2024

[Problem] Suppressed objects are not distinguishable #12361

Closed

2 tasks

FlachyJoe force-pushed the suppressibleExt branch 2 times, most recently from 210ee56 to 50aa554 Compare February 15, 2024 18:03

FlachyJoe force-pushed the suppressibleExt branch from d08541f to cec9f17 Compare February 16, 2024 11:00

FlachyJoe changed the title ~~[WIP] Core: Create a SuppressibleExtension to provide the Suppressed property to all the WBs~~ Core: Create a SuppressibleExtension to provide the Suppressed property to all the WBs Feb 16, 2024

FlachyJoe marked this pull request as ready for review February 16, 2024 11:04

FlachyJoe mentioned this pull request Feb 16, 2024

PD: Use SuppressibleExtension #12447

Merged

FlachyJoe force-pushed the suppressibleExt branch from cec9f17 to a7ecd66 Compare February 16, 2024 11:38

FlachyJoe marked this pull request as draft February 17, 2024 08:13

FlachyJoe force-pushed the suppressibleExt branch from a7ecd66 to 15ef32f Compare February 17, 2024 10:40

FlachyJoe marked this pull request as ready for review February 17, 2024 10:44

FlachyJoe mentioned this pull request Feb 20, 2024

[Feature Request] PartDesign: Temporarily Suppress / Hide Features - Add to UI #11212

Open

2 tasks

FlachyJoe force-pushed the suppressibleExt branch from 15ef32f to 59e8536 Compare February 21, 2024 15:15

FlachyJoe added 2 commits February 21, 2024 16:19

Add SuppressibleExtension

5a22009

Add Suppress action to contextmenu

735fed0

FlachyJoe force-pushed the suppressibleExt branch from 59e8536 to 735fed0 Compare February 21, 2024 15:20

chennes merged commit d144e85 into FreeCAD:main Feb 26, 2024
9 checks passed

PaddleStroke reviewed Feb 27, 2024

View reviewed changes

PaddleStroke mentioned this pull request Feb 27, 2024

Fix ViewProviderSuppressibleExtension #12639

Merged

FlachyJoe deleted the suppressibleExt branch March 1, 2024 21:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core: Create a SuppressibleExtension to provide the Suppressed property to all the WBs #12412

Core: Create a SuppressibleExtension to provide the Suppressed property to all the WBs #12412

FlachyJoe commented Feb 14, 2024 •

edited

FlachyJoe commented Feb 15, 2024 •

edited

FlachyJoe commented Feb 15, 2024

FlachyJoe commented Feb 16, 2024

FlachyJoe commented Feb 17, 2024

FlachyJoe commented Feb 17, 2024

wwmayer commented Feb 17, 2024

FlachyJoe commented Feb 17, 2024

FlachyJoe commented Feb 21, 2024

PaddleStroke commented Feb 27, 2024 •

edited

PaddleStroke Feb 27, 2024

PaddleStroke Feb 27, 2024

PaddleStroke Feb 27, 2024

PaddleStroke Feb 27, 2024

FlachyJoe commented Feb 29, 2024

PaddleStroke commented Mar 1, 2024

FEA-eng commented Mar 5, 2024

FlachyJoe commented Mar 5, 2024

Core: Create a SuppressibleExtension to provide the Suppressed property to all the WBs #12412

Core: Create a SuppressibleExtension to provide the Suppressed property to all the WBs #12412

Conversation

FlachyJoe commented Feb 14, 2024 • edited

FlachyJoe commented Feb 15, 2024 • edited

FlachyJoe commented Feb 15, 2024

FlachyJoe commented Feb 16, 2024

FlachyJoe commented Feb 17, 2024

FlachyJoe commented Feb 17, 2024

wwmayer commented Feb 17, 2024

FlachyJoe commented Feb 17, 2024

FlachyJoe commented Feb 21, 2024

PaddleStroke commented Feb 27, 2024 • edited

PaddleStroke Feb 27, 2024

Choose a reason for hiding this comment

PaddleStroke Feb 27, 2024

Choose a reason for hiding this comment

PaddleStroke Feb 27, 2024

Choose a reason for hiding this comment

PaddleStroke Feb 27, 2024

Choose a reason for hiding this comment

FlachyJoe commented Feb 29, 2024

PaddleStroke commented Mar 1, 2024

FEA-eng commented Mar 5, 2024

FlachyJoe commented Mar 5, 2024

FlachyJoe commented Feb 14, 2024 •

edited

FlachyJoe commented Feb 15, 2024 •

edited

PaddleStroke commented Feb 27, 2024 •

edited