Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path.Area: respect zero start point when generating path #1244

Closed
wants to merge 1 commit into from

Conversation

realthunder
Copy link
Collaborator

Related to issue #3129

Relevant forum thread https://forum.freecadweb.org/viewtopic.php?f=15&t=23451

@ghost
Copy link

ghost commented Jan 22, 2018

DONT AGREE on THIS
the almost farest Point is a Better way to get it Started
Dressups Dogbone /dragnive/leadin caculate on Q lines WILL FAIL if the First move is not present
AS Tool DEFAULT pos is 0,0,Clear
THIS Might Rip the SYSTEM
libarea heeks does Find the Best Point it is not involved
BETTER To not start at ZERO let the system CALC a BEST START

@realthunder
Copy link
Collaborator Author

Path.Area is not facing end user directly. Path workbench has an end-user facing parameter to let user decide whether to manual or auto select the start position. This PR is just to enable user manual selecting the zero point as a start position for whatever reason.

@ghost
Copy link

ghost commented Jan 22, 2018

My English may not good enough to understand the thinking behind
THE User has Ever Had the opportunity to select a Start point After the Default where set
by the GUI selected a Point First
OR is my understanding Wrong and you added a Mouseklick Startpoint to the Base OP

@realthunder
Copy link
Collaborator Author

This PR did not touch anything in Path GUI

@ghost
Copy link

ghost commented Jan 22, 2018

@realthunder It Touches the Startline that 3 Dreeups calculating the Main entry angel
Tool is at 0,0.clear
first move will be non planar only Z depth not Regionised as XY as we All Bearly Calc on this line Angle on this RED line you take away!
We will see how it comes out with non Planar Startpoint
Dogbone and DragKnive reli on 3 lines
i gone with leadin on 2 as SOMEone might change the Circle mode to FULLCircle insted of 4Quaters i got the 2 lines MIN as there are only 2 lines in this MODE ZerotoStart,Circle

@realthunder
Copy link
Collaborator Author

@sliptonic can you please comment onthis?

@sliptonic
Copy link
Member

I've pulled the PR code and it seems to be working correctly. @IchGucksLive: All the path work and dressup is downstream from this change. Please pull realthunder's code and test it yourself. If you can find a case where it breaks, please comment here. We'll leave the PR pending for a couple days to test.

@realthunder: thanks.

@wwmayer wwmayer changed the title Path.Area: respect zero start point when generating path [Pending]Path.Area: respect zero start point when generating path Jan 22, 2018
@sliptonic
Copy link
Member

This is good to go. Please merge.

@luzpaz
Copy link
Contributor

luzpaz commented Jan 23, 2018

TravisCI error is from the OSX build:

-- Xerces-C was not found.
CMake Error at CMakeLists.txt:615 (MESSAGE):
  ==================
  XercesC not found.

ref: https://travis-ci.org/FreeCAD/FreeCAD/jobs/331707043#L553-L559

@wwmayer
Copy link
Contributor

wwmayer commented Jan 23, 2018

Merged.

@wwmayer wwmayer closed this Jan 23, 2018
@wwmayer wwmayer changed the title [Pending]Path.Area: respect zero start point when generating path Path.Area: respect zero start point when generating path Jan 23, 2018
@realthunder realthunder deleted the PathAreaStart branch September 25, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants