New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path.Area: respect zero start point when generating path #1244
Conversation
DONT AGREE on THIS |
Path.Area is not facing end user directly. Path workbench has an end-user facing parameter to let user decide whether to manual or auto select the start position. This PR is just to enable user manual selecting the zero point as a start position for whatever reason. |
My English may not good enough to understand the thinking behind |
This PR did not touch anything in Path GUI |
@realthunder It Touches the Startline that 3 Dreeups calculating the Main entry angel |
@sliptonic can you please comment onthis? |
I've pulled the PR code and it seems to be working correctly. @IchGucksLive: All the path work and dressup is downstream from this change. Please pull realthunder's code and test it yourself. If you can find a case where it breaks, please comment here. We'll leave the PR pending for a couple days to test. @realthunder: thanks. |
This is good to go. Please merge. |
TravisCI error is from the OSX build:
ref: https://travis-ci.org/FreeCAD/FreeCAD/jobs/331707043#L553-L559 |
Merged. |
Related to issue #3129
Relevant forum thread https://forum.freecadweb.org/viewtopic.php?f=15&t=23451