Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gui: PythonWrapper::fromQAction #12577

Merged
merged 6 commits into from
Mar 3, 2024
Merged

Gui: PythonWrapper::fromQAction #12577

merged 6 commits into from
Mar 3, 2024

Commits on Mar 3, 2024

  1. Gui: Implement PythonWrapper::fromQAction 

    Wrapping QAction through QObject does not work as QAction class
is a part of QtGui not QtCore, so Py::Object with internal
pointer being null is returned causing a crash later.
Therefore implement fromQAction conversion method.
    @3x380V
    3x380V committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    b7ccffe View commit details
    Browse the repository at this point in the history

  2. Gui: PythonWrapper: Raise exception on qt_wrapInstance failure 

    When qt_wrapInstance fails it returns Py::Object with internal
pointer set to null. Make PythonWrapper::from* methods raise
exception when this happens to be consistent with PySide code path.
    @3x380V
    3x380V committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    63989bd View commit details
    Browse the repository at this point in the history

  3. Gui: PythonWrapper: Use getPyTypeObjectForTypeName consistently

    @3x380V
    3x380V committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    13f2ba5 View commit details
    Browse the repository at this point in the history

  4. Gui: PythonWrapper: Fix possible crash in qt_wrapInstance

    @wwmayer @3x380V
    wwmayer authored and 3x380V committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    88620c3 View commit details
    Browse the repository at this point in the history

  5. Gui: PythonWrapper: Make qt_getCppType more robust 

    Handle gracefully possible shiboken's Python API changes.
    @wwmayer @3x380V
    wwmayer authored and 3x380V committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    7c6a691 View commit details
    Browse the repository at this point in the history

  6. Gui: PythonWrapper: Consolidate typeName handling 

    Use typeName consistently for both PySide and Python interface
code paths.
    @3x380V
    3x380V committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    8af4dba View commit details
    Browse the repository at this point in the history