New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New FEM CalculiX incrementation settings #12662
Conversation
Sorry for the delay. |
No problem. Done, thanks. Is the rest of the code ok (mainly default, min and max possible values of the new properties)? |
src/Mod/Fem/Gui/DlgSettingsFemCcx.ui
Outdated
</widget> | ||
</item> | ||
<item row="7" column="1"> | ||
<spacer name="horizontalSpacer_2"> | ||
<property name="orientation"> | ||
<enum>Qt::Horizontal</enum> | ||
</property> | ||
<property name="sizeHint" stdset="0"> | ||
<size> | ||
<width>40</width> | ||
<height>20</height> | ||
</size> | ||
</property> | ||
</spacer> | ||
</item> | ||
<item row="7" column="2"> | ||
<widget class="Gui::PrefDoubleSpinBox" name="dsb_ccx_minimum_time_step"> | ||
<property name="contextMenuPolicy"> | ||
<enum>Qt::DefaultContextMenu</enum> | ||
</property> | ||
<property name="alignment"> | ||
<set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set> | ||
</property> | ||
<property name="decimals"> | ||
<number>9</number> | ||
</property> | ||
<property name="minimum"> | ||
<double>0.000000001000000</double> | ||
</property> | ||
<property name="singleStep"> | ||
<double>0.010000000000000</double> | ||
</property> | ||
<property name="value"> | ||
<double>0.000010000000000</double> | ||
</property> | ||
<property name="prefEntry" stdset="0"> | ||
<cstring>AnalysisTimeMinimumStep</cstring> | ||
</property> | ||
<property name="prefPath" stdset="0"> | ||
<cstring>Mod/Fem/Ccx</cstring> | ||
</property> | ||
</widget> | ||
</item> | ||
<item row="7" column="3"> | ||
<widget class="QLabel" name="l_hz_3"> | ||
<property name="text"> | ||
<string>s</string> | ||
</property> | ||
</widget> | ||
</item> | ||
<item row="8" column="0"> | ||
<widget class="QLabel" name="l_ccx_maximum_time_step"> | ||
<property name="text"> | ||
<string>Time Maximum Step</string> | ||
</property> | ||
</widget> | ||
</item> | ||
<item row="8" column="1"> | ||
<spacer name="horizontalSpacer_2"> | ||
<property name="orientation"> | ||
<enum>Qt::Horizontal</enum> | ||
</property> | ||
<property name="sizeHint" stdset="0"> | ||
<size> | ||
<width>40</width> | ||
<height>20</height> | ||
</size> | ||
</property> | ||
</spacer> | ||
</item> | ||
<item row="8" column="2"> | ||
<widget class="Gui::PrefDoubleSpinBox" name="dsb_ccx_maximum_time_step"> | ||
<property name="contextMenuPolicy"> | ||
<enum>Qt::DefaultContextMenu</enum> | ||
</property> | ||
<property name="alignment"> | ||
<set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set> | ||
</property> | ||
<property name="decimals"> | ||
<number>9</number> | ||
</property> | ||
<property name="minimum"> | ||
<double>0.000000001000000</double> | ||
</property> | ||
<property name="singleStep"> | ||
<double>1.000000000000000</double> | ||
</property> | ||
<property name="value"> | ||
<double>1.000000000000000</double> | ||
</property> | ||
<property name="prefEntry" stdset="0"> | ||
<cstring>AnalysisTimeMaximumStep</cstring> | ||
</property> | ||
<property name="prefPath" stdset="0"> | ||
<cstring>Mod/Fem/Ccx</cstring> | ||
</property> | ||
</widget> | ||
</item> | ||
<item row="8" column="3"> | ||
<widget class="QLabel" name="l_hz_3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a specific class Gui::PrefQuantitySpinBox that uses units inside the spin box, there is no need to combine a PrefDoubleSpinBox with an additional unit label (as currently used in the file).
Do not repeat widget names to avoid a warning on compilation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a specific class Gui::PrefQuantitySpinBox that uses units inside the spin box, there is no need to combine a PrefDoubleSpinBox with an additional unit label (as currently used in the file).
I would leave it for now because it has always been like that in this file. I can try to correct it in another PR.
Do not repeat widget names to avoid a warning on compilation.
Corrected.
src/Mod/Fem/Gui/DlgSettingsFemCcx.ui
Outdated
<item row="4" column="0"> | ||
<widget class="QLabel" name="l_ccx_max_iterations"> | ||
<property name="text"> | ||
<string>Maximum number of iterations</string> | ||
</property> | ||
</widget> | ||
</item> | ||
<item row="4" column="2"> | ||
<widget class="Gui::PrefSpinBox" name="sb_ccx_max_iterations"> | ||
<property name="minimum"> | ||
<number>1</number> | ||
</property> | ||
<property name="maximum"> | ||
<number>10000000</number> | ||
</property> | ||
<property name="singleStep"> | ||
<number>10</number> | ||
</property> | ||
<property name="value"> | ||
<number>2000</number> | ||
</property> | ||
<property name="prefEntry" stdset="0"> | ||
<cstring>AnalysisMaxIterations</cstring> | ||
</property> | ||
<property name="prefPath" stdset="0"> | ||
<cstring>Mod/Fem/Ccx</cstring> | ||
</property> | ||
</widget> | ||
</item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix value alignment like in the other widgets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was like this before but I corrected it now.
@marioalexis84 I've noticed that the 2 new properties (Time Minimum Step and Time Maximum Step) are getting reset when changed from defaults in Preferences. What I mean is that I change them, click OK and go back to Preferences only to see them unchanged. Do you know what can be the cause? |
And in the
Note that |
@marioalexis84 Thanks a lot, it's working now. |
fixes #12357
@marioalexis84 Can you check it?