Sketcher: Chamfer tool (and fillet refactor)

[PaddleStroke]

• Rework fillet tool, so that preserve corner is a checkbox not a separate tool.
• Introduce Chamfer tool.
• Few syntax fixes/modernization in fillet()
• unrelated but fix error in className of CmdSketcherCompHorizontalVertical
  
  Fixes [Problem] Sketcher: No OVP/Widget for Fillet Tool #12464 (though there is no OVP introduced)
  Fixes [Feature Request] Add Chamfer Edge-Tool #5623

[FEA-eng]

• Introduce Chamfer tool.

Awesome to see this pretty much last major missing tool in the sketcher being added. Can I help with testing or is it too early as the PR is still in draft?

[PaddleStroke]

If you can test it would be great. It's already finished.

[FEA-eng]

Very good decision to turn the separate corner-preserving fillet tool into a checkbox. The new chamfer tool works very well too. Here are some minor comments:

1. Fillet and chamfer are separate tools but when one of them is activated, the mode can be changed to the other tool. Doesn't it mean that they should be unified into a single fillet/chamfer tool?
2. The preserve corner checkbox is shown also for the chamfer mode but it has no use there, right? Moreover, it becomes unchecked automatically after the first use of the tool but it seems to be still in effect.
3. Do you plan to add the on-view parameters for those tools so that the user is asked for the fillet radius or chamfer size before the feature is created?

[PaddleStroke]

1. I think it's best to keep them separate as they are usually separate tools in other cads.
2. Preserve corner works with chamfer as well. This needs to be fixed.
3. It's hard to implement OVP for fillet because of how the internal works. It would need much more work and I'm kind of swamped right now so if it comes it will be later.

[FEA-eng]

1. I think it's best to keep them separate as they are usually separate tools in other cads.

Sure, I don't mind it at all. I just thought that it was a bit different than the other tools but then I realized that it's already like this with some shape (circle/rectangle) drawing tools so never mind. Let's keep them separated.

3. It's hard to implement OVP for fillet because of how the internal works. It would need much more work and I'm kind of swamped right now so if it comes it will be later.

Sure, it's nothing urgent. Just a minor suggestion for the future.

[maxwxyz]

Nice to see this! A few questions:

• Is preserve corners checked by default?
• Does it work with 2 edges (lines/conics) and also just with 1 point?
• Does it work with a preselection?
• If OVP is too much work for now, would a radius constraint be feasible or should this be postponed to later as well?

[PaddleStroke]

• yes
• yes
• No, as fillet current doesn't.
• You mean create a radius constraint automatically? But then it can be annoying, say if you want to make 5 fillet and make them equal. If it creates a radius on every use it's bad

[maxwxyz]

OK thanks, that's good.

[PaddleStroke]

Small issue with the checkbox reseting itself to false fixed.

[FEA-eng]

I tested this again, the only small issue is indeed gone and it all works as expected.