Gui: fix several regressions caused by PR #12035 #13033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wwmayer
commented
Mar 18, 2024
wwmayer
commented
- fix hard crash in MainWindow::_updateActions() if no MDI view exists
- in MDIView::buildWindowTitle() use the label of the document because this changes when saving it while the name is immutable
- fix const correctness in MDIView::buildWindowTitle()
- do not set the modified flag of the main window in MDIView::buildWindowTitle() but in the calling instance
- move setting the main window title to Application::viewActivated to reduce code duplication
- fix missing application name if FreeCADGui is loaded as Python module
* fix hard crash in MainWindow::_updateActions() if no MDI view exists * in MDIView::buildWindowTitle() use the label of the document because this changes when saving it while the name is immutable * fix const correctness in MDIView::buildWindowTitle() * do not set the modified flag of the main window in MDIView::buildWindowTitle() but in the calling instance * move setting the main window title to Application::viewActivated to reduce code duplication * fix missing application name if FreeCADGui is loaded as Python module
github-actions
bot
added
the
Core
This was referenced Mar 19, 2024
This was
linked to
issues
Mar 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.