UI: update hardcoded XPMs to .svg files. Updated .svg icons for clarity. #13110
Conversation
github-actions
bot
added
Core
maxwxyz
force-pushed
the
tree-overlay-icons
branch
from
4d81a61
to
5be71c4
Compare
| ".######.", | ||
| "..####.."}; | ||
| static QPixmap forbidden_icon(forbidden_xpm); | ||
| static QPixmap forbidden_icon(Gui::BitmapFactory().pixmapFromSvg("forbidden", QSize(8, 8))); |
There was a problem hiding this comment.
Here you can use a size of 24x24 or 32x32 as otherwise the overlay icon will be too small.
There was a problem hiding this comment.
but the icon will be displayed too large then. When I scale it down after a higher resolution with .scaled
Do I need to call the get dpr every time then, if #13176 is in?
There was a problem hiding this comment.
When using 8x8 then the overlay icon is extremely tiny. With 24x24 or 32x32 the size is sensible for me. Not sure why because in the past 8x8 was OK.
There was a problem hiding this comment.
This is how it looks with 8x8 (XPM and SVG):
and this with 24x24:
There was a problem hiding this comment.
On Windows it looks like the bottom one with the 10x10 or 8x8
There was a problem hiding this comment.
You can at least use it in DocumentObjectItem::testStatus() where you can access the tree widget.
There was a problem hiding this comment.
but overlay icons are set from almost all WBs. Could this be integrated in pixmapFromSvg() instead? If no DPR is given, calculate it there?
There was a problem hiding this comment.
No, as this only makes no sense. On systems with several monitors it's possible that widgets have different DPR and pixmapFromSvg() doesn't know anything about the context a pixmap is used.
There was a problem hiding this comment.
how is it working with toolbar icons? On my second monitor DPI they also look good. dragging them from one to another monitor updates them.
There was a problem hiding this comment.
I don't know. I guess Qt does it automatically.
See files for overview.
fix partially #6765
fix partially #12992