Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to customize all material colors #13495

Merged
merged 5 commits into from Apr 22, 2024
Merged

Conversation

wwmayer
Copy link
Contributor

@wwmayer wwmayer commented Apr 16, 2024

  • Add setPackedRGB() and getPackedRGB() to Color class
  • Read material colors from settings
  • Support of material colors in settings

@github-actions github-actions bot added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB Part Related to the Part Workbench Materials Materials related labels Apr 16, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Apr 16, 2024

is it ideal to have a default color (actually more like a material) based on defined preferences? Why not use a default material picker in the preferences, we already have a material called "Default"?
@davesrocketshop FYI

@davesrocketshop
Copy link
Contributor

is it ideal to have a default color (actually more like a material) based on defined preferences? Why not use a default material picker in the preferences, we already have a material called "Default"? @davesrocketshop FYI

This is a planned update. The original merge was intended as minimal viable product to find and fix issues as soon as possible. There will be a follow on that addresses this.

@wwmayer
Copy link
Contributor Author

wwmayer commented Apr 16, 2024

is it ideal to have a default color (actually more like a material) based on defined preferences?

After having changed the specular colour of the default material to light grey (f6f8243b7e3c) we need a way to let the user customize it because in several cases the bright reflection can be very annoying:

Why not use a default material picker in the preferences, we already have a material called "Default"?

A user has to set the material for every newly created object over and over again. IMO, this isn't very user-friendly.

@luzpaz luzpaz added the Color Regarding the color handling label Apr 17, 2024
src/App/Color.cpp Outdated Show resolved Hide resolved
@chennes chennes merged commit 2326d3c into FreeCAD:main Apr 22, 2024
9 checks passed
@wwmayer wwmayer deleted the material_colors branch April 22, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Color Regarding the color handling Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Materials Materials related WB Part Related to the Part Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants