Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fem: Constraint symbol scaling based on shape size - fixes #7030 #13586

Merged
merged 1 commit into from Apr 29, 2024

Conversation

marioalexis84
Copy link
Member

@marioalexis84 marioalexis84 commented Apr 22, 2024

To be merged after #13274.
@FEA-eng could you test? The last commit fixes #7030 (initial scaling for very small and big objects).
Scaling is based on a characteristic length of the objects, basically the diagonal of the bounding box, so symbols scale linearly with the shapes.

@github-actions github-actions bot added the WB FEM Related to the FEM Workbench label Apr 22, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Apr 22, 2024

nice!
please add "fixes #7030" in your comment, I cannot manually link this issue.

@FEA-eng
Copy link
Contributor

FEA-eng commented Apr 22, 2024

Great, I tested this with both tiny and huge geometries and it works very well.

@marioalexis84 marioalexis84 marked this pull request as ready for review April 22, 2024 09:43
@marioalexis84
Copy link
Member Author

@chennes this PR is ready.

@chennes chennes merged commit ba0825f into FreeCAD:main Apr 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB FEM Related to the FEM Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] FEM: Adjust constraint indicators to the size of the model
4 participants