New XP icons for Qsint dialog #13697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Core
|
In your new screenshot, the text is not visible, I hope this is not part of the PR |
|
@maxwxyz I was just working on a dark XP theme, and tested in that theme. So the last screenshot was only to check how it would look. |
|
It's a small but really nice change. Those icons are so common that it's good to have them in a better quality. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same Icons less kb more pixels what more do you want?
All icons are round too.
It is this icon:
New one in my stylesheet:
I think my margins are a bit off, but I do expect the new icon the be displayed smaller since, it is actually fully round. The older icon where the sides cut off.