Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fem: Make pipeline filters invisible if a new filter is added #13701

Closed

Conversation

marioalexis84
Copy link
Member

This pull request is aimed at fixing issues #13660 and #13695 making all elements in the pipeline invisible if a new filter is added.

@FEA-eng these changes satisfy the second point of your proposal. The first is more specific to CalculiX features. Can you divide the issue in two?
@maxwxyz I can't reproduce (but I saw that behavior in the past) your second case when editing the warp filter. Can you give more specific steps to reproduce?

@github-actions github-actions bot added the WB FEM Related to the FEM Workbench label Apr 29, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Apr 29, 2024

I can't reproduce (but I saw that behavior in the past) your second case when editing the warp filter. Can you give more specific steps to reproduce?

just add another warp filter or any other filter to a result pipeline with an active warp filet (set a deformation and color output). As soon as another filter is added, the original is red, until you select it in the tree.
Also just add one warp filter, set settings and click ok. Douple click on the filter to edit it gain --> all is red, until you select it in the tree.

@marioalexis84
Copy link
Member Author

Now I can reproduce (In my case the filter turns green). This pull request will hide the problem since it makes the pipeline filters invisible, but in any case there is something wrong in the handling of the internal data.

@FEA-eng
Copy link
Contributor

FEA-eng commented Apr 29, 2024

Thanks, I’ll have a look at this next week because I’m on a vacation.

@maxwxyz
Copy link
Collaborator

maxwxyz commented Apr 30, 2024

It works. But I'd leave #13695 open as you've mentioned.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 3, 2024

will the deletion or change of visibility of the last filter make the next filter visible?

@marioalexis84
Copy link
Member Author

will the deletion or change of visibility of the last filter make the next filter visible?

In general, I think that the program should not assume too much about user intentions.

I close this pull request in favor of #13820.
In that PR, #13695 is solved and only the input filter is hidden. The other filters in the pipeline maintain their visibility status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB FEM Related to the FEM Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants