CAM: Added tests for A, B, and C parameters to the linuxcnc post (Draft) #13702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have posted the question in the forum at https://forum.freecad.org/viewtopic.php?t=87233. |
This was referenced Apr 29, 2024
Merged
Also added code to keep A, B, C parameters from changing with --inches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added code to linuxcnc_post.py to keep A, B, C parameters from changing when the --inches option is used.
This is a replacement for #11575 which was closed by accident by my error.
This should become a partial fix for #11445 once the possible conflicting use for the A, B, and C parameters in the recent change from "for c in pathobj.Path.Commands" to "for c in PathUtils.getPathWithPlacement(pathobj).Commands" is figured out. It appears to me that the use of the A, B, and C parameters in the rest of the code is in conflict with how the Path code uses the A, B, and C parameters.
I need some help to understand this possible conflict.