Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MeasureGui] Make initial measurement placement scale with viewport zoom #13848

Merged
merged 1 commit into from
May 27, 2024

Conversation

hlorus
Copy link
Contributor

@hlorus hlorus commented May 6, 2024

Currently the initial positioning of UMF measurements is static which often feels out of place as described in #13808.

This PR improves the behavior by:

  • scaling the distance/angle measurement offsets with openinventors "getWorldToScreenScale" factor
  • offsetting the annotation label text in screenspace and converting it to a 3d location

@chennes
Copy link
Member

chennes commented May 20, 2024

@hlorus it looks like you had a git rebase issue -- can you clean this up? Let me know if you need help with it.

@hlorus
Copy link
Contributor Author

hlorus commented May 21, 2024

@chennes the rebase issue should be fixed now

@chennes chennes merged commit 8066107 into FreeCAD:main May 27, 2024
9 checks passed
@furgo16
Copy link
Contributor

furgo16 commented May 27, 2024

Fixes #13808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants