Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toponaming: Bring in Chamfer, Fillet code and add tests #14035

Merged
merged 4 commits into from
May 15, 2024

Conversation

bgbsww
Copy link
Contributor

@bgbsww bgbsww commented May 15, 2024

GetElementName is just relocated within the file to ease side-by-side comparisons. No changes to it.

@github-actions github-actions bot added WB Part Design Related to the Part Design Workbench WB Part Related to the Part Workbench WB Sketcher Related to the Sketcher Workbench labels May 15, 2024
@bgbsww bgbsww marked this pull request as draft May 15, 2024 16:24
@bgbsww bgbsww force-pushed the bgbsww-toponamingMissingPartDesignTests6 branch 2 times, most recently from 7b1355b to 65c6d41 Compare May 15, 2024 19:20
@bgbsww bgbsww marked this pull request as ready for review May 15, 2024 20:00
@bgbsww bgbsww force-pushed the bgbsww-toponamingMissingPartDesignTests6 branch from 65c6d41 to 4f0b05e Compare May 15, 2024 21:00
@chennes chennes merged commit b72a8c4 into FreeCAD:main May 15, 2024
8 of 9 checks passed
@bgbsww bgbsww deleted the bgbsww-toponamingMissingPartDesignTests6 branch May 16, 2024 01:46
@chennes chennes self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Part Design Related to the Part Design Workbench WB Part Related to the Part Workbench WB Sketcher Related to the Sketcher Workbench
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants