Link accumulated fixes

src/App/PropertyGeo.cpp

@@ -584,7 +584,7 @@ void PropertyPlacement::setValue(const Base::Placement &pos)
 bool PropertyPlacement::setValueIfChanged(const Base::Placement &pos,double tol,double atol)
 {
     if(_cPos.getPosition().IsEqual(pos.getPosition(),tol)
-            && _cPos.getRotation().isSame(pos.getRotation(),atol))
+            && _cPos.getRotation().isSimilar(pos.getRotation(),atol))
     {
         return false;
     }

src/Base/Console.cpp

@@ -331,7 +331,7 @@ void ConsoleSingleton::Error( const char *pMsg, ... )
 
 void ConsoleSingleton::Log( const char *pMsg, ... )
 {
-    if (!_bVerbose)
+    if (_bVerbose)
     {
         FC_CONSOLE_FMT(Log,Log);
     }

src/Base/Matrix.cpp

@@ -954,7 +954,7 @@ int Matrix4D::hasScale(double tol) const {
     // scaling factors are the column vector length. We use square distance and
     // ignore the actual scaling signess
     //
-    if(!tol)
+    if(tol == 0.0)
         tol = 1e-9;
     double dx = Vector3d(dMtrx4D[0][0],dMtrx4D[1][0],dMtrx4D[2][0]).Sqr();
     double dy = Vector3d(dMtrx4D[0][1],dMtrx4D[1][1],dMtrx4D[2][1]).Sqr();

src/Base/Rotation.cpp

@@ -396,10 +396,10 @@ bool Rotation::isSame(const Rotation& q) const
     return false;
 }
 
-bool Rotation::isSame(const Rotation& q, double tol) const
+bool Rotation::isSimilar(const Rotation& q, double tol) const
 {
-    Vector3d v(0,0,1);
-    return std::fabs(multVec(v).GetAngle(q.multVec(v))) < tol;
+    double dot = q.quat[0]*quat[0]+q.quat[1]*quat[1]+q.quat[2]*quat[2]+q.quat[3]*quat[3];
+    return fabs(dot) >= 1.0 - tol;
 }
 
 Vector3d Rotation::multVec(const Vector3d & src) const {

src/Base/Rotation.h

@@ -87,7 +87,7 @@ class BaseExport Rotation
     Vector3d multVec(const Vector3d & src) const;
     void scaleAngle(const double scaleFactor);
     bool isSame(const Rotation&) const;
-    bool isSame(const Rotation&, double tol) const;
+    bool isSimilar(const Rotation&, double tol) const;
     //@}
 
     /** Specialty constructors */

src/Gui/ActiveObjectList.h

@@ -59,7 +59,7 @@ namespace Gui
             return dynamic_cast<_T>(getObject(it->second,true,parent,subname));
         }
         void setObject(App::DocumentObject*, const char*, const char *subname=0,
-                const Gui::HighlightMode& m = Gui::LightBlue);
+                const Gui::HighlightMode& m = Gui::UserDefined);
         bool hasObject(const char*)const;
         void objectDeleted(const ViewProviderDocumentObject& viewProviderIn);
         bool hasObject(App::DocumentObject *obj, const char *, const char *subname=0) const;

src/Gui/Application.cpp

@@ -958,6 +958,9 @@ void Application::setActiveDocument(Gui::Document* pcDocument)
 {
     if (d->activeDocument == pcDocument)
         return; // nothing needs to be done
+
+    getMainWindow()->updateActions();
+
     if (pcDocument) {
         // This happens if a document with more than one view is about being
         // closed and a second view is activated. The document is still not

src/Gui/Application.h

@@ -251,6 +251,7 @@ class GuiExport Application
     static PyObject* sAddCommand               (PyObject *self,PyObject *args);
     static PyObject* sListCommands             (PyObject *self,PyObject *args);
     static PyObject* sIsCommandActive          (PyObject *self,PyObject *args);
+    static PyObject* sUpdateCommands           (PyObject *self,PyObject *args);
 
     static PyObject* sHide                     (PyObject *self,PyObject *args); // deprecated
     static PyObject* sShow                     (PyObject *self,PyObject *args); // deprecated

src/Gui/ApplicationPy.cpp

@@ -141,6 +141,9 @@ PyMethodDef Application::Methods[] = {
   {"listCommands",               (PyCFunction) Application::sListCommands, METH_VARARGS,
    "listCommands() -> list of strings\n\n"
    "Returns a list of all commands known to FreeCAD."},
+  {"updateCommands()",        (PyCFunction) Application::sUpdateCommands, METH_VARARGS,
+   "updateCommands()\n\n"
+   "Update all command active status"},
   {"SendMsgToActiveView",     (PyCFunction) Application::sSendActiveView, METH_VARARGS,
    "deprecated -- use class View"},
   {"sendMsgToFocusView",     (PyCFunction) Application::sSendFocusView, METH_VARARGS,
@@ -1236,6 +1239,14 @@ PyObject* Application::sIsCommandActive(PyObject * /*self*/, PyObject *args)
     }PY_CATCH;
 }
 
+PyObject* Application::sUpdateCommands(PyObject * /*self*/, PyObject *args)
+{
+    if (!PyArg_ParseTuple(args, ""))
+        return NULL;
+
+    getMainWindow()->updateActions();
+    Py_Return;
+}
 
 PyObject* Application::sListCommands(PyObject * /*self*/, PyObject *args)
 {

src/Gui/Document.cpp

@@ -772,6 +772,8 @@ void Document::slotChangedObject(const App::DocumentObject& Obj, const App::Prop
         FC_LOG(Prop.getFullName() << " modified");
         setModified(true);
     }
+
+    getMainWindow()->updateActions(true);
 }
 
 void Document::slotRelabelObject(const App::DocumentObject& Obj)

src/Gui/MainWindow.cpp

@@ -1001,7 +1001,6 @@ void MainWindow::setActiveWindow(MDIView* view)
     onSetActiveSubWindow(view->parentWidget());
     d->activeView = view;
     Application::Instance->viewActivated(view);
-    updateActions();
 }
 
 void MainWindow::onWindowActivated(QMdiSubWindow* w)
@@ -1025,7 +1024,6 @@ void MainWindow::onWindowActivated(QMdiSubWindow* w)
     // set active the appropriate window (it needs not to be part of mdiIds, e.g. directly after creation)
     d->activeView = view;
     Application::Instance->viewActivated(view);
-    updateActions();
 }
 
 void MainWindow::onWindowsMenuAboutToShow()

src/Gui/PropertyView.cpp

@@ -136,6 +136,12 @@ PropertyView::PropertyView(QWidget *parent)
     this->connectDelDocument = 
         Application::Instance->signalDeleteDocument.connect(
                 boost::bind(&PropertyView::slotDeleteDocument, this, _1));
+    this->connectDelViewObject = 
+        Application::Instance->signalDeletedObject.connect(
+                boost::bind(&PropertyView::slotDeletedViewObject, this, _1));
+    this->connectDelObject = 
+        App::GetApplication().signalDeletedObject.connect(
+                boost::bind(&PropertyView::slotDeletedObject, this, _1));
 }
 
 PropertyView::~PropertyView()
@@ -149,6 +155,8 @@ PropertyView::~PropertyView()
     this->connectRedoDocument.disconnect();
     this->connectActiveDoc.disconnect();
     this->connectDelDocument.disconnect();
+    this->connectDelObject.disconnect();
+    this->connectDelViewObject.disconnect();
 }
 
 static bool _ShowAll;
@@ -253,6 +261,25 @@ void PropertyView::slotDeleteDocument(const Gui::Document &doc) {
         propertyEditorView->buildUp();
         propertyEditorData->buildUp();
         clearPropertyItemSelection();
+        timer->start(50);
+    }
+}
+
+void PropertyView::slotDeletedViewObject(const Gui::ViewProvider &vp) {
+    if(propertyEditorView->propOwners.count(&vp)) {
+        propertyEditorView->buildUp();
+        propertyEditorData->buildUp();
+        clearPropertyItemSelection();
+        timer->start(50);
+    }
+}
+
+void PropertyView::slotDeletedObject(const App::DocumentObject &obj) {
+    if(propertyEditorData->propOwners.count(&obj)) {
+        propertyEditorView->buildUp();
+        propertyEditorData->buildUp();
+        clearPropertyItemSelection();
+        timer->start(50);
     }
 }
 
@@ -297,10 +324,7 @@ void PropertyView::onSelectionChanged(const SelectionChanges& msg)
         return;
 
     // clear the properties.
-    propertyEditorData->buildUp();
-    propertyEditorView->buildUp();
-    clearPropertyItemSelection();
-    timer->start(100);
+    timer->start(50);
 }
 
 void PropertyView::onTimer() {
@@ -310,6 +334,9 @@ void PropertyView::onTimer() {
     clearPropertyItemSelection();
     timer->stop();
 
+    if(!this->isConnectionAttached())
+        return;
+
     if(!Gui::Selection().hasSelection()) {
         auto gdoc = TreeWidget::selectedDocument();
         if(!gdoc || !gdoc->getDocument())
@@ -335,36 +362,11 @@ void PropertyView::onTimer() {
     std::vector<PropInfo> propViewMap;
     bool checkLink = true;
     ViewProviderDocumentObject *vpLast = 0;
-    const auto &array = Gui::Selection().getCompleteSelection(false);
-    for(auto &sel : array) {
-        if(!sel.pObject) continue;
-        App::DocumentObject *parent = 0;
-        App::DocumentObject *ob = sel.pObject->resolve(sel.SubName,&parent);
+    auto sels = Gui::Selection().getSelectionEx("*");
+    for(auto &sel : sels) {
+        App::DocumentObject *ob = sel.getObject();
         if(!ob) continue;
 
-        // App::Link should be able to handle special case below now, besides, the new
-        // support of plain group in App::Link breaks because of the code below
-#if 0
-        if(parent) {
-            auto parentVp = Application::Instance->getViewProvider(parent);
-            if(parentVp) {
-                // For special case where the SubName reference can resolve to
-                // a non-child object (e.g. link array element), the tree view
-                // will select the parent instead.  So we shall show the
-                // property of the parent as well.
-                bool found = false;
-                for(auto child : parentVp->claimChildren()) {
-                    if(ob == child) {
-                        found = true;
-                        break;
-                    }
-                }
-                if(!found)
-                    ob = parent;
-            }
-        }
-#endif
-
         // Do not process an object more than once
         if(!objSet.insert(ob).second)
             continue;
@@ -491,7 +493,7 @@ void PropertyView::onTimer() {
     dataPropsMap.clear();
 
     for (it = propDataMap.begin(); it != propDataMap.end(); ++it) {
-        if (it->propList.size() == array.size()) {
+        if (it->propList.size() == sels.size()) {
             if(it->propList[0]->testStatus(App::Property::PropDynamic))
                 dataPropsMap.emplace(it->propName, std::move(it->propList));
             else
@@ -502,10 +504,10 @@ void PropertyView::onTimer() {
     for(auto &v : dataPropsMap)
         dataProps.emplace_back(v.first,std::move(v.second));
 
-    propertyEditorData->buildUp(std::move(dataProps));
+    propertyEditorData->buildUp(std::move(dataProps),true);
 
     for (it = propViewMap.begin(); it != propViewMap.end(); ++it) {
-        if (it->propList.size() == array.size())
+        if (it->propList.size() == sels.size())
             viewProps.emplace_back(it->propName, std::move(it->propList));
     }
 

src/Gui/PropertyView.h

@@ -89,6 +89,8 @@ public Q_SLOTS:
     void slotRollback();
     void slotActiveDocument(const Gui::Document&);
     void slotDeleteDocument(const Gui::Document&);
+    void slotDeletedViewObject(const Gui::ViewProvider&);
+    void slotDeletedObject(const App::DocumentObject&);
 
     void checkEnable(const char *doc = 0);
 
@@ -105,6 +107,8 @@ public Q_SLOTS:
     Connection connectRedoDocument;
     Connection connectActiveDoc;
     Connection connectDelDocument;
+    Connection connectDelObject;
+    Connection connectDelViewObject;
     QTabWidget* tabs;
     QTimer* timer;
 };

src/Gui/TaskView/TaskView.cpp

@@ -44,6 +44,7 @@
 #include <Gui/ViewProvider.h>
 #include <Gui/Control.h>
 #include <Gui/ActionFunction.h>
+#include <Gui/MainWindow.h>
 
 #if defined (QSINT_ACTIONPANEL)
 #include <Gui/QSint/actionpanel/taskgroup_p.h>
@@ -613,10 +614,14 @@ void TaskView::showDialog(TaskDialog *dlg)
     ActiveDialog = dlg;
 
     ActiveDialog->open();
+
+    getMainWindow()->updateActions();
 }
 
 void TaskView::removeDialog(void)
 {
+    getMainWindow()->updateActions();
+
     if (ActiveCtrl) {
         taskPanel->removeWidget(ActiveCtrl);
         delete ActiveCtrl;

src/Gui/Tree.cpp

@@ -785,8 +785,6 @@ void TreeWidget::contextMenuEvent (QContextMenuEvent * e)
 {
     // ask workbenches and view provider, ...
     MenuItem view;
-    view << "Std_TreeViewActions";
-
     Gui::Application::Instance->setupContextMenu("Tree", &view);
 
     view << "Std_Expressions";
@@ -836,47 +834,36 @@ void TreeWidget::contextMenuEvent (QContextMenuEvent * e)
         DocumentObjectItem* objitem = static_cast<DocumentObjectItem*>
             (this->contextItem);
 
-        auto selItems = this->selectedItems();
-        // if only one item is selected setup the edit menu
-        if (selItems.size() == 1) {
-
-            auto cmd = Gui::Application::Instance->commandManager().getCommandByName("Std_LinkSelectLinked");
-            if(cmd && cmd->isActive())
-                cmd->addTo(&contextMenu);
-            cmd = Gui::Application::Instance->commandManager().getCommandByName("Std_LinkSelectLinkedFinal");
-            if(cmd && cmd->isActive())
-                cmd->addTo(&contextMenu);
-
-            objitem->object()->setupContextMenu(&editMenu, this, SLOT(onStartEditing()));
-            QList<QAction*> editAct = editMenu.actions();
-            if (!editAct.isEmpty()) {
-                contextMenu.addSeparator();
-                for (QList<QAction*>::iterator it = editAct.begin(); it != editAct.end(); ++it)
-                    contextMenu.addAction(*it);
-                QAction* first = editAct.front();
-                contextMenu.setDefaultAction(first);
-                if (objitem->object()->isEditing())
-                    contextMenu.addAction(finishEditingAction);
-            }
-        }
-
-        contextMenu.addSeparator();
-
         App::Document* doc = objitem->object()->getObject()->getDocument();
         showHiddenAction->setChecked(doc->ShowHidden.getValue());
         contextMenu.addAction(this->showHiddenAction);
 
         hideInTreeAction->setChecked(!objitem->object()->showInTree());
         contextMenu.addAction(this->hideInTreeAction);
 
-        contextMenu.addAction(this->searchObjectsAction);
-
         if (objitem->object()->getObject()->isDerivedFrom(App::DocumentObjectGroup::getClassTypeId()))
             contextMenu.addAction(this->createGroupAction);
 
         contextMenu.addAction(this->markRecomputeAction);
         contextMenu.addAction(this->recomputeObjectAction);
         contextMenu.addAction(this->relabelObjectAction);
+
+        auto selItems = this->selectedItems();
+        // if only one item is selected setup the edit menu
+        if (selItems.size() == 1) {
+            objitem->object()->setupContextMenu(&editMenu, this, SLOT(onStartEditing()));
+            QList<QAction*> editAct = editMenu.actions();
+            if (!editAct.isEmpty()) {
+                QAction* topact = contextMenu.actions().front();
+                for (QList<QAction*>::iterator it = editAct.begin(); it != editAct.end(); ++it)
+                    contextMenu.insertAction(topact,*it);
+                QAction* first = editAct.front();
+                contextMenu.setDefaultAction(first);
+                if (objitem->object()->isEditing())
+                    contextMenu.insertAction(topact, this->finishEditingAction);
+                contextMenu.insertSeparator(topact);
+            }
+        }
     }
 
 
@@ -4408,6 +4395,7 @@ void DocumentObjectItem::setHighlight(bool set, Gui::HighlightMode high) {
     default:
         break;
     }
+    this->setFont(0,f);
 }
 
 const char *DocumentObjectItem::getTreeName() const {