Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Layers override #2726

Closed
wants to merge 2 commits into from
Closed

Conversation

JeromeL63
Copy link
Contributor

Separate line and shape colors override

@JeromeL63 JeromeL63 changed the title Draft.Layers [Draft] Layers override Nov 19, 2019
@vocx-fc
Copy link
Contributor

vocx-fc commented Nov 20, 2019

I strongly suggest you split your single pull request into two pull requests, because you are introducing two separate things. One is the new Arch_CutLine in the Arch Workbench, and the other is a change to the Draft Layer behavior in the Draft Workbench.

You should also reference a thread in the forum where the changes are discussed.

See the forum thread: draft layer separate line and shape color override

@berndhahnebach
Copy link
Contributor

If you would make a separate PR for the layer changing I would merge it immediately but mergeing a new tool in Draft or Arch needs to pass Yoriks eyes.

@JeromeL63
Copy link
Contributor Author

Hello, I have no time this week to do that, it's a mistake. I haven't separated layer override and the new cut with line feature.
I'll try to separate them next week if I can, and make 2 PR separated :'(

@JeromeL63 JeromeL63 closed this Dec 3, 2019
@JeromeL63 JeromeL63 deleted the master_me branch December 3, 2019 13:42
@JeromeL63
Copy link
Contributor Author

JeromeL63 commented Dec 3, 2019

Ok. Done:
#2749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants