Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added to grbl_post optional bCNC block header for every job operation #3014

Merged
merged 1 commit into from Feb 6, 2020

Conversation

spanner888
Copy link
Contributor

@spanner888 spanner888 commented Feb 6, 2020

Dev forum discussion https://forum.freecadweb.org/viewtopic.php?f=15&t=42956&p=366887#p366887
Added in minimal way, ie did not convert ALL existing comment blocks to
bCNC format, as either existing seemed preferred, or already wored as
bCNC header blocks.

Enabling with --bcnc argument (not default) adds () gcode comment blocks
in bCNC format to provide colapsable blocks that can be dragged in bCNC
to edit or alows en/diable in the job.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

  • Branch rebased on latest master git pull --rebase upstream master
  • [Sorry - Do not have suitable build computer (Stuck in ChinaATM) Also change to to single Path post processor file and grbl output has been tested in bCNC] Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • [na] Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.


Added in minimal way, ie did not convert ALL existing comment blocks to
bCNC format, as either existing seemed preferred, or already wored as
bCNC header blocks.

Enabling with --bcnc argument (not default) adds () gcode comment blocks
in bCNC format to provide colapsable blocks that can be dragged in bCNC
to edit or alows en/diable in the job.
@sliptonic sliptonic merged commit 5d42d45 into FreeCAD:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants