Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path: 3D Surface and Waterline fixes per forum identification #3556

Merged
merged 9 commits into from Jun 4, 2020

Conversation

Russ4262
Copy link
Contributor

@Russ4262 Russ4262 commented Jun 3, 2020

Fixes include:

  1. Fix missing connections between tasks panel and operation in Gui module and UI panel.
  2. Fix paths cutting through model. This needs more testing.
  3. Fix AvoidLastX_Faces breakage of 3D Surface.
  4. Add missing cut patterns to enumerations list.
  5. Improvements to debug messages and temporary object creation.
  6. Fixes STL creation issue identified in forum at Error at 3D Surfaceing.

Forum identification and discussion also at Re: Separate 3D Surface and Waterline (new feature) [Merged].

Not all issues identified in the linked forum post are resolved here due to inability to reproduce them on my Windows 10 machine.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.


@Russ4262 Russ4262 force-pushed the 3D_Surface_Waterline_Fixes branch 2 times, most recently from e1b7fb3 to 51a5005 Compare June 3, 2020 23:52
@Russ4262 Russ4262 force-pushed the 3D_Surface_Waterline_Fixes branch from 51a5005 to 9ca8554 Compare June 4, 2020 00:01
@sliptonic sliptonic merged commit be7e780 into FreeCAD:master Jun 4, 2020
@Russ4262 Russ4262 deleted the 3D_Surface_Waterline_Fixes branch June 5, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants