Part: fix handling of attachment offset rotation changes in attachment editor #3670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the non-deterministic behaviour of the rotation controls in the attachment editor(s) as discussed here. The problem was caused the way how the internal quaternion representation of the rotation was updated from the Euler angels representation in the GUI. When the user changed a single component of the Euler angle, then the event handler first converted the internal quaternion representation back into Euler angles and then replaced only that component by the new value provided by the user. The problem with this approach is that the quaternion-Euler transformation is ambiguous. So, it can happen that the transformation leads to other Euler angles than shown in the GUI. In that case one cannot simply replace one component of the Euler angles.
Now the proposed fix always reads all Euler angles components and transforms them into the quaternion.
git pull --rebase upstream master
./bin/FreeCAD --run-test 0
issue #<id>
orfixes #<id>
where<id>
is the associated MantisBT issue id if one exists