Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part: fix handling of attachment offset rotation changes in attachment editor #3670

Merged
merged 1 commit into from Jul 4, 2020

Conversation

thomasgi1
Copy link
Contributor

This pull request fixes the non-deterministic behaviour of the rotation controls in the attachment editor(s) as discussed here. The problem was caused the way how the internal quaternion representation of the rotation was updated from the Euler angels representation in the GUI. When the user changed a single component of the Euler angle, then the event handler first converted the internal quaternion representation back into Euler angles and then replaced only that component by the new value provided by the user. The problem with this approach is that the quaternion-Euler transformation is ambiguous. So, it can happen that the transformation leads to other Euler angles than shown in the GUI. In that case one cannot simply replace one component of the Euler angles.
Now the proposed fix always reads all Euler angles components and transforms them into the quaternion.

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

@abdullahtahiriyo
Copy link
Contributor

Closed and reopened to trigger Travis CI

@abdullahtahiriyo abdullahtahiriyo merged commit ffbcab5 into FreeCAD:master Jul 4, 2020
@thomasgi1 thomasgi1 deleted the attachmentFix branch July 12, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants