[PartDesign Hole] Add reversed checkbox to dialog #3800
Conversation
|
Built & tested that both the property changes in dialog & property pane and also that the hole does reverse direction. OS: Debian GNU/Linux 10 (buster) (XFCE/xfce) |
|
Thanks for testing. |
There was a problem hiding this comment.
This change is relatively straightforward - a Qt qui-element appears to have been added in the ".ui" file, a corresponding "slot" added to the "TaskHoleParameters.h" file, and finally the implementation in the cpp file.
Everything looks correct, and from other comments this change appears to work as expected.
| @@ -258,7 +258,7 @@ | |||
| </property> | |||
| </widget> | |||
| </item> | |||
| <item row="22" column="2"> | |||
| <item row="23" column="2"> | |||
There was a problem hiding this comment.
Why does this row number need to change?
There was a problem hiding this comment.
Good eye. Initially I had the Reversed checkbox below the Tapered checkbox, and I had moved the vertical spacer down to the next row, but then I decided to put the Reversed checkbox on the same row as the Tapered checkbox so users would be less likely to need to scroll down as it's already a fairly tall dialog. When I moved the Reversed checkbox up I guess I forgot to also move the spacer back up to where it was originally.
There was a problem hiding this comment.
👍 I doubt the row number actually makes a difference, but it's probably worth changing it back to avoid confusing future devs.
|
Merged. One minor issue: when opening the dialog the value of the Reversed checkbox should be restored: 666682d |
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:
git pull --rebase upstream master./bin/FreeCAD --run-test 0issue #<id>orfixes #<id>where<id>is the associated MantisBT issue id if one existsAnd please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.