[Path] Integrated first version of LibLathe #3852
Conversation
| xmlns:svg="http://www.w3.org/2000/svg" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| xmlns:xlink="http://www.w3.org/1999/xlink" | ||
| xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" |
There was a problem hiding this comment.
This was created with Inkscape, and the file was saved as "Inkscape SVG". This introduces non-standard tags so it is advisible to save SVG files as "Plain SVG". For icons it's not a big issue, but in certain cases these Inkscape SVG may not be parsed correctly by every software.
src/Mod/Path/LibLathe/LICENSE
Outdated
| GNU GENERAL PUBLIC LICENSE | ||
| Version 2, June 1991 |
There was a problem hiding this comment.
What is this LibLathe exactly? Is this an external library?
FreeCAD is licensed LGPL2, therefore, all files that are included in the source code must be licensed LGPL2 as well, or be compatible with it (MIT, BSD). This LibLathe library cannot be included in the source code if it has GPL2 license. This library can be installed and used at run time, but it cannot be provided together with FreeCAD. For example, see the DXF library that is used in the Draft Workbench. This library can be installed from an online repository, but it is not included together with the Draft Workbench.
Alternatively, if the LibLathe is re-licensed to LGPL2 by its author, then it can be included in FreeCAD without problems.
|
Forum thread: LibLathe - Lathe Path Generation |
|
The functionalilty included in this PR has now been moved to an addon to encourage testing. Addon Here: |
|
Closing this for now. Additional work being done prior to merge |
Integrated support for lathe ops with LibLathe
@dubstar-04