Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEM: Added read nastran95 inp file ability in FemMesh.cpp #4009

Closed
wants to merge 3 commits into from
Closed

FEM: Added read nastran95 inp file ability in FemMesh.cpp #4009

wants to merge 3 commits into from

Conversation

ceanwang
Copy link
Contributor

src/Mod/Fem/App/FemMesh.cpp Outdated Show resolved Hide resolved
@ceanwang ceanwang closed this Dec 6, 2020
@luzpaz
Copy link
Contributor

luzpaz commented Dec 7, 2020

@ceanwang why did you close it ?

@ceanwang
Copy link
Contributor Author

ceanwang commented Dec 8, 2020

Seems nothing is happening. I give up.

@luzpaz
Copy link
Contributor

luzpaz commented Dec 8, 2020

@berndhahnebach ping

@berndhahnebach berndhahnebach reopened this Dec 9, 2020
@berndhahnebach
Copy link
Contributor

have some patience. I am really busy ... christmas time is familly time ... Furthermore there are some dead lines in my daily job before christmas ...

@luzpaz
Copy link
Contributor

luzpaz commented Jan 27, 2021

@berndhahnebach any idea at what point you'll have time to address this PR ?

@wwmayer
Copy link
Contributor

wwmayer commented Feb 4, 2021

I have merged it now.

It's a bit weird that the same file extension (.inp) is used for Abaqus and Nastran-95 files. The difficulty of this PR was that it doesn't handle both formats at the same time but basically disabled the Abaqus support.

So, I solved it this way: if an inp file is given then FreeCAD first tries the Abaqus importer and if afterwards the mesh is empty (i.e. it has no nodes) the Nastran-95 imported is used.

Btw, here is a link to a file that can be used for testing: https://forum.freecadweb.org/viewtopic.php?f=18&t=39234&start=10#p412743

@wwmayer wwmayer closed this Feb 4, 2021
@ceanwang
Copy link
Contributor Author

ceanwang commented Feb 4, 2021 via email

@berndhahnebach
Copy link
Contributor

It's a bit weird that the same file extension (.inp) is used for Abaqus and Nastran-95 files. The difficulty of this PR was that it doesn't handle both formats at the same time but basically disabled the Abaqus support.

BTW: this was the reason I did not merge it myself earlier.

@berndhahnebach
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants