Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start: encode basename to avoid crashes on non-ascii file names #4092

Merged
merged 2 commits into from Dec 1, 2020

Conversation

steelman
Copy link
Contributor

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.


@luzpaz
Copy link
Contributor

luzpaz commented Nov 29, 2020

Please fix typo in PR name s/endode/encode

@steelman steelman changed the title Start: endode filname to avoid crash on non-ascii file name Start: encode basename to avoid crashes on non-ascii file names Nov 29, 2020
@chennes
Copy link
Member

chennes commented Nov 29, 2020

Is there a bug report or forums topic about this one? I'm not seeing crashes on non-ASCII filenames on my Win10 system.

@steelman
Copy link
Contributor Author

steelman commented Nov 29, 2020

No, I haven't filed one. On Debian 10 with FreeCAD linked against Python 2.7 I've got

'ascii' codec can't decode byte 0xc5 in position 8: ordinal not in range(128)

after editing a file with a non-ascii character in its name and the Start Page is blank.

@wwmayer wwmayer merged commit a8da70e into FreeCAD:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants