Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PartDesign: New Text utility #4255

Closed
wants to merge 4 commits into from

Conversation

davidosterberg
Copy link
Contributor

@davidosterberg davidosterberg commented Jan 6, 2021

Allow for easy and parametric additive and subractive text features in PartDesign.

Work is very much in progress. No need for detail review at this stage.

Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=19&t=53833

image
demo1

What works

  • Font selection with QFontComboBox
  • Generation of text shapes

Todo:

  • Fix segfault when recomputing
  • Implement the text location by sketch logic
  • Ship a small selection of fonts with FreeCAD, so that models using those fonts will be platform independent, and distinguish these in the UI.
  • implement subractive, additive, and imprint modes by observing the sign of the input
  • Filter out non TrueType fonts from QFontComboBox (subclass?)
  • Scale text to exact desired height by means of Bounding box command.

@davidosterberg davidosterberg marked this pull request as draft January 6, 2021 19:20
@hyarion
Copy link
Contributor

hyarion commented Jan 7, 2021

I like that this makes it easier to create parametric text, but I am wondering if a specific tool for it is necessary. Wouldn't it be better to create the parametric text in 2d and use pad/pocket to make it 3d? (that way it could be possible to use create 3d text with sweep and partial revolve too.

Is there a forum thread where this feature is being discussed?

@davidosterberg
Copy link
Contributor Author

davidosterberg commented Jan 7, 2021

@hyarion there is no forum thread yet (will create one soon). The 2D contour approach exists in Draft -> ShapeString. This is PartDesign and in PD and IMO it is more appropriate to this WB to create a feature directly on the body.

Edit: Actually there was a thread that I forgot about. Added.

Edit2:
The main use cases I see for this is that you want some kind of text on your part. E.g an item and batch number for a casting. My main priority is that the tool is both fast and self explanatory for this use case.

Edit3:
Perhaps it is possible to do both in some way. The tool could offer the user to import the shape of the text as a new sketch.

@hyarion
Copy link
Contributor

hyarion commented Jan 7, 2021

@davidosterberg ok, thanks I'll continue the discussion there instead

@davidosterberg
Copy link
Contributor Author

Closed, in favor of a Sketcher based solution. See forum discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants