[GUI] Fix minor issues with Workbenches preference panel #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes three issues with the new Workbench Loader preferences panel reported by users: * Some icons were not being properly scaled to the new 48x48 size * Some text was being incorrectly cut off, despite fitting in the column * The sort order of the workbenches was incorrect when external workbenches were added
chennes
referenced
this pull request
Feb 5, 2021
A new group is added to the Preferences window that explains why some preferences may appear to be missing due to the workbench being unloaded. It lists the unloaded workbenches, and offers to load them, updating the preferences dialog as necessary. This at least partially resolves issue #4474.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three issues with the new Workbench Loader preferences panel reported by users:
git pull --rebase upstream master./bin/FreeCAD --run-test 0