[0.20] PartDesign: Hole performance improvements #4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidosterberg
force-pushed
the
pd-hole-performance
branch
from
b83a7d7
to
354ab55
Compare
davidosterberg
changed the title
|
If PR #4274 should go in for 0.19, this PR is really necessary. |
11 tasks
davidosterberg
force-pushed
the
pd-hole-performance
branch
3 times, most recently
from
afab001
to
ef834ed
Compare
davidosterberg
force-pushed
the
pd-hole-performance
branch
from
ef834ed
to
3b10ba2
Compare
- Remove unused code - BooleanOperation trick For some reason doing the cut in a boolean operation is 20% faster than doing it directly. Unclear why.
davidosterberg
force-pushed
the
pd-hole-performance
branch
from
3b10ba2
to
8f97d60
Compare
|
@wwmayer, Any objections to this being merged? |
No, but I just haven't had the time yet to test it. I will have a look today afternoon/evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR #4274, the hole feature can be very slow if thread modeling is enabled for a large hole pattern.
This PR contains some performance optimization. With debug build the performance improvement is about 30%.
A note about changes in behavior.
Previously it was posssible for the holes to overlap each other. Now this is no-longer supported as this would be more computationally demanding. If it is seen as needed to support overlapping holes, support for overlapping holes can be implemented if necessary.