[0.19] [Path] Add UseOutline feature to Adaptive op [1 of 3 per dev conversation]
#4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working edges must be identified from Base Geometry selection features, discretized, and added to list for return value.
This was referenced Feb 7, 2021
sliptonic
changed the title
UseOutline feature to Adaptive op [1 of 3 per dev conversation]UseOutline feature to Adaptive op [1 of 3 per dev conversation]
mlampert
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isolates the addition of the
UseOutlinefeature to the Adaptive operation at found in PR #4324 . The feature is cloned from PocketShape.I recommend consideration of PR #4345 as a possible chaser. It adds a simple Adaptive test framework to the Path workbench test suite and is already coded for testing this
UseOutlinefeature.Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:
git pull --rebase upstream master./bin/FreeCAD --run-test 0issue #<id>orfixes #<id>where<id>is the associated MantisBT issue id if one existsAnd please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.