[PATH] toolbits: hide confusing unused cutting edge height #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On angled tools such as v-bit and chamfer the cutting edge height is redundant since it determined by other dimensions and is generally not given by manufacturers. It is unused by OCL and not needed for paths. As such its presence is just a cause of confusion for the user. This PR simply hides the inputs for these two tool types. https://forum.freecadweb.org/viewtopic.php?f=15&t=54880&p=478425#p478425
|
This PR should not be merged it's misguided. The cutting edge height is needed on this tool and it's not what you think it is. |
|
Following a link to the branch on the CI-repository: https://gitlab.com/berndhahnebach/FreeCAD/-/commits/PR_5060 The CI-status is available on the latest commit of the branch. https://gitlab.com/berndhahnebach/FreeCAD/-/pipelines?scope=branches |
|
Closing this PR. It appears to be unmaintained and the issues were not resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On angled tools such as v-bit and chamfer the cutting edge height is redundant since it determined by other dimensions and is generally not given by manufacturers.
It is unused by OCL and not needed for paths. As such its presence is just a cause of confusion for the user.
This PR simply hides the inputs for these two tool types.
https://forum.freecadweb.org/viewtopic.php?f=15&t=54880&p=478425#p478425
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!
App,Base,Guior one of theModsubfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master./bin/FreeCAD --run-test 0Fixes typo in Draft Move command textDraft: Fixed typosissue #<id>orfixes #<id>where<id>is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex:Draft: fix typos - fixes #0004805And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.
Also changes the title of the initial save dialogue to indicate clearly what is happening. "Tool" gave no idea what it was doing and why there was another dlg shown.