Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui: Update usability enhancements to ProDark theme #4586

Merged
merged 1 commit into from Mar 8, 2021
Merged

Gui: Update usability enhancements to ProDark theme #4586

merged 1 commit into from Mar 8, 2021

Conversation

turn211
Copy link
Contributor

@turn211 turn211 commented Mar 5, 2021

forum thread: https://forum.freecadweb.org/viewtopic.php?f=34&t=55134

LineEdit, QComboBox ans QListView color enhancements for easier editing useablity. Bim View Manager Icon separation and background transparency. HyperLinks color changed in line of https://forum.freecadweb.org/viewtopic.php?f=34&t=55844&start=10

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.


ipatch pushed a commit to ipatch/FreeCAD that referenced this pull request Mar 5, 2021
@luzpaz
Copy link
Contributor

luzpaz commented Mar 7, 2021

This should also probably get merged in v0.19

@wwmayer wwmayer merged commit d8faa26 into FreeCAD:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants