[Path] Add seven initial 'PocketShape` unit tests #4940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Russ4262
force-pushed
the
feature/pocketshape_unit_tests
branch
from
8eb2dd1
to
146a500
Compare
Russ4262
force-pushed
the
feature/pocketshape_unit_tests
branch
from
146a500
to
121094a
Compare
Add seven initial unit tests for the PocketShape op: - default values check - verify Use Outline feature - basic functionality - verify no overhang detection - verify Extra Offset (material allowance) - verify full circle exterior extension - verify multi-height face combination with extension The small change to PathOpGui.ViewProvider() class allows for proper addition of view provider without initial interaction with the Task Panel.
Russ4262
force-pushed
the
feature/pocketshape_unit_tests
branch
from
121094a
to
edd7048
Compare
|
Following a link to the branch on the CI-repository: https://gitlab.com/freecad/FreeCAD-CI/-/commits/PR_4940 The CI-status is available on the latest commit of the branch. https://gitlab.com/freecad/FreeCAD-CI/-/pipelines?scope=branches |
|
Rebased. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add seven initial unit tests for the PocketShape op:
The small change to PathOpGui.ViewProvider() class allows for addition of view provider without initial interaction with the Task Panel. Learning this, I might make some changes to part of PR #4797 that is related to creation of GUI ops without initial Task Panel support.
These unit tests do not contain specific tests targeted at cut pattern path generation. They do compare output paths, mostly using the
Offsetcut pattern.As of the creation of this PR, there is one FEM unit test not passing when running
./bin/FreeCADCmd --run-test 0.Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!
App,Base,Guior one of theModsubfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master./bin/FreeCAD --run-test 0Fixes typo in Draft Move command textDraft: Fixed typosissue #<id>orfixes #<id>where<id>is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex:Draft: fix typos - fixes #0004805And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.