[Macros Dialog]Add preference to begin search for unique suggested fi… #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chennes
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
This compiles, runs, and works as advertised. My only hesitation is whether it's worth having a visible preference in the Preferences dialog for so small a tweak -- maybe we should discuss either making this an invisible preference, or just making this the standard behavior and dropping the preference altogether.
mwganson
force-pushed
the
macroduplicate
branch
from
47f7173
to
8ddb94e
Compare
FreeCAD#4949) * [PD] Add new need active body dialog Intended for use wherever an active body is needed but none exists. The dialog contains a list with the bodies present in the document, with an extra option to make a new body. Custom text can be provided if needed. This commit also replaces the warnings used by "new sketch" and "primitive" command with this new dialog. Addresses issue FreeCAD#4288. [Macros Dialog] search for unique name beginning with current backup number when using duplicate
mwganson
force-pushed
the
macroduplicate
branch
from
8ddb94e
to
c2a44e7
Compare
|
I tried to squash the first commit, but goofed it up. I might have to close this one and open another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lename with current @NNN rather than always 001
Currently, when using Duplicate button in Macros dialog the search for a suggested filename always begins with "@001", ignoring the current "@NNN" if the macro has already been duplicated and already has "@NNN". Some examples of current implementation:
some_macro.FCMacro (original)
some_macro@001.FCMacro (first duplicate)
some_macro@002.FCMacro (2nd duplicate)
If some_macro@001.FCMacro is deleted and we now have:
some_macro.FCMacro
some_macro@002.FCMacro
If we choose to duplicate some_macro@002.FCMacro the suggested name will be some_macro@001.FCMacro because the search for a unique filename always begins with 001.
With this PR if the user sets the preference (DuplicateFrom001) to false in the above scenario when the user duplicates some_macro@002.FCMacro the suggested name will be some_macro@003.FCMacro.
This is a feature requested by Mario, most prolific author of macros in the community.
https://forum.freecadweb.org/viewtopic.php?p=276152#p276152
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!
App,Base,Guior one of theModsubfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master./bin/FreeCAD --run-test 0Fixes typo in Draft Move command textDraft: Fixed typosissue #<id>orfixes #<id>where<id>is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex:Draft: fix typos - fixes #0004805And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.