Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: fix 2 edit mode issues #5058

Merged
merged 2 commits into from Sep 24, 2021

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Sep 23, 2021

2 edit mode issues were fixed:

  1. Double clicking a Draft object in the Tree would result in an error if the Draft WB was not loaded. Now there is a warning.
  2. The introduction of Std_UserEditMode means that edit mode can be non-zero. This required a modification of the unsetEdit function.

Forum discussion about issue 1: https://forum.freecadweb.org/viewtopic.php?f=23&t=59179

@0penBrain Can you have a look at the unsetEdit function? Maybe there is a better way to do this?

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@berndhahnebach berndhahnebach added the WB Draft Related to the Draft Workbench label Sep 23, 2021
@berndhahnebach
Copy link
Contributor

@0penBrain
Copy link
Contributor

@Roy-043 This looks totally good to me :)

@berndhahnebach
Copy link
Contributor

Following a link to the branch on the CI-repository:

https://gitlab.com/berndhahnebach/FreeCAD/-/commits/PR_5060

The CI-status is available on the latest commit of the branch.
If there is no status available the PR should be rebased on latest master.
Check pipeline branches to see if your PR has been run by the CI.

https://gitlab.com/berndhahnebach/FreeCAD/-/pipelines?scope=branches

@chennes chennes merged commit 0e03427 into FreeCAD:master Sep 24, 2021
@Roy-043 Roy-043 deleted the Draft-fix-2-edit-mode-issues branch September 24, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants