Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Path] Fix Waterline error due to invalid arguments in getOffsetArea() calls #5097

Merged
merged 2 commits into from Jan 7, 2022

Conversation

Russ4262
Copy link
Contributor

@Russ4262 Russ4262 commented Oct 7, 2021

This commit fixes the error reported in the forum at Re: Waterline milling update.

This error was introduced when a contributor replaced the extractFaceOffset() method from the PathSurfaceSupport.py module with an improved getOffsetArea() function in the PathUtils.py module. The two instances of the improved getOffsetArea() calls here in this fix did not get corrected (updated argument lists) when that improvement was originally made. This fix corrects the argument lists in the two function calls.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


This commit fixes the error reported in the forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=33121&start=50#p537787.

This error was introduced when another user replaced the `extractFaceOffset()` method from the PathSurfaceSupport.py module with an improved `getOffsetArea()` function in the PathUtils.py module.  The two instances of the improved `getOffsetArea()` calls here in this fix did not get corrected when that improvement was originally made.
@freecadci
Copy link

pipeline status for feature branch PR_5097. Pipeline #384021798 was triggered at c35e44d. All CI branch pipelines.

@berndhahnebach berndhahnebach added the WB CAM Related to the CAM/Path Workbench label Oct 7, 2021
@sliptonic sliptonic merged commit 1381744 into FreeCAD:master Jan 7, 2022
@Russ4262 Russ4262 deleted the fix/waterline branch March 30, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB CAM Related to the CAM/Path Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants