Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daft: fix cleanProjection (used by Draft_Shape2DView and DXF export) #5114

Merged
merged 2 commits into from Oct 19, 2021

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Oct 15, 2021

This fixes the bug where straight edges were missing from tessellated Shape2DViews. The code was also simplified.

Forum topic: https://forum.freecadweb.org/viewtopic.php?f=23&t=58975

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@chennes
Copy link
Member

chennes commented Oct 16, 2021

@berndhahnebach CI doesn't seem to have triggered on this one...

@freecadci
Copy link

pipeline statusfor feature branch PR_5114. Pipeline #389509856 was triggered at 7da4273. All CI branch pipelines.

@chennes chennes merged commit cf1a0f7 into FreeCAD:master Oct 19, 2021
@Roy-043 Roy-043 deleted the Daft-fix-cleanProjection branch October 19, 2021 08:58
@luzpaz
Copy link
Contributor

luzpaz commented Oct 20, 2021

@chennes can you modify the history to fix the typo of the git commit from Daft to Draft ? 🤕

@chennes
Copy link
Member

chennes commented Oct 20, 2021

Haha, I kind of like "daft"! Joking aside, it's a bad idea to force-push onto the main development branch, too many people will have copies with the old commit, which causes confusion later when that commit is missing from the depot.

@luzpaz
Copy link
Contributor

luzpaz commented Oct 20, 2021

Bummer that there is not other case scenario that makes that possible without disrupting other forks. Thanks for the follow-up 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants