Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PD] UserEditMode : fix operating on PartDesignObject #5204

Closed
wants to merge 1 commit into from

Conversation

0penBrain
Copy link
Contributor

No description provided.

@freecadci
Copy link

pipeline status for feature branch PR_5204. Pipeline 417423674 was triggered at 3a03551. All CI branches and pipelines.

@donovaly
Copy link
Member

The fix works but I must admit that I don't have the knowledge yet to understand what side effects on the PD WB could occur.

@0penBrain
Copy link
Contributor Author

@donovaly I had asked in the past information about that but never get an answer. So I choose to move on and thoroughly test the behavior. I didn't find anything weird so pushed the PR. But better if someone with a good understanding of what's running under the hood can review.

@donovaly
Copy link
Member

You did everything right. It is just that I don't know yet enough to judge the PR. I asked already Werner to have a look.

@donovaly donovaly changed the title [Gui] UserEditMode : fix operating on PartDesignObject [PD] UserEditMode : fix operating on PartDesignObject Nov 29, 2021
@donovaly donovaly added the WB Part Design Related to the Part Design Workbench label Nov 29, 2021
@wwmayer
Copy link
Contributor

wwmayer commented Dec 3, 2021

But better if someone with a good understanding of what's running under the hood can review.

The PR is fine and as side-effect makes things even more consistent because the doubleClicked() function should do exactly the same as when you open the context-menu and click the bold item.

@wwmayer
Copy link
Contributor

wwmayer commented Dec 3, 2021

Merged by hand since the first line needs to be removed: 7aef0b3

@wwmayer wwmayer closed this Dec 3, 2021
@0penBrain
Copy link
Contributor Author

@wwmayer Thx. Sorry for missing the unused variable in the commit. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Part Design Related to the Part Design Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants