Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part --> CompoundFilter #526

Closed
wants to merge 4 commits into from

Conversation

berndhahnebach
Copy link
Contributor

@berndhahnebach berndhahnebach commented Feb 16, 2017

see forum topic:
http://forum.freecadweb.org/viewtopic.php?f=8&t=16773

especially starting from post:
http://forum.freecadweb.org/viewtopic.php?f=8&t=16773&start=10#p159031

cheers bernd

I have no glue what to do in the regard of all these new cool icon stuff. I just added one icon.

__title__ = "CompoundTools.CompoundFilter"
__author__ = "DeepSOIC, Bernd Hahnebach"
__url__ = "http://www.freecadweb.org"
__doc__ = "Compound Filter: remove some childs from a compound (features)."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/childs/children/

__doc__ = """CompoundTools Package (part of FreeCAD)."""

## @package CompoundTools
# \ingroup PART
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# \brief CompoundTools Package for Part workbench

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done see rebase under this comment ...

@wwmayer
Copy link
Contributor

wwmayer commented Feb 17, 2017

I consider this problematic: Base::Interpreter().runString("__import__('CompoundTools').importAll()"); because:

  • it won't work with Python 3 because there the import mechanism works differently. CompoundTools are imported in Part but at this point the Part module is not yet initialized. Now CompoundTools tries to load Part too and then the initPart is called again which again tries to load CompoundTools and so on. This is a cyclic dependency and leads to a stack overflow
  • CompoundTools is part of Part (not PartGui) but also deals with GUI stuff. In core modules I want to have a strict separation between App (i.e. non-GUI) and Gui stuff.

@berndhahnebach
Copy link
Contributor Author

Ahh I got your point but I do not yet have an idea how to do this better. This part was copied from uptodate master. The BOPTools use the same code already. See

bernd

@wwmayer
Copy link
Contributor

wwmayer commented Feb 17, 2017

The BOPTools use the same code already. See

Exactly! That's why I know it leads to problems there. IMO, there is no need to put this import statement into the init function. It can e.g. also be put into the Initialize() method of the Workbench class (see InitGui.py).

@berndhahnebach
Copy link
Contributor Author

#531

@wwmayer
Copy link
Contributor

wwmayer commented Feb 17, 2017

Replaced by #531

@wwmayer wwmayer closed this Feb 17, 2017
@berndhahnebach berndhahnebach deleted the bhbdev068 branch February 18, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants