New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part --> CompoundFilter #526
Conversation
4eb4aaf
to
afdd179
Compare
__title__ = "CompoundTools.CompoundFilter" | ||
__author__ = "DeepSOIC, Bernd Hahnebach" | ||
__url__ = "http://www.freecadweb.org" | ||
__doc__ = "Compound Filter: remove some childs from a compound (features)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/childs/children/
__doc__ = """CompoundTools Package (part of FreeCAD).""" | ||
|
||
## @package CompoundTools | ||
# \ingroup PART |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# \brief CompoundTools Package for Part workbench
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done see rebase under this comment ...
515d0c4
to
59205c4
Compare
- add CompoundTools menue enty - add command to FreeCAD GUI
59205c4
to
4c1fc6d
Compare
I consider this problematic:
|
Ahh I got your point but I do not yet have an idea how to do this better. This part was copied from uptodate master. The BOPTools use the same code already. See FreeCAD/src/Mod/Part/App/AppPart.cpp Line 370 in 1463a26
bernd |
Exactly! That's why I know it leads to problems there. IMO, there is no need to put this import statement into the init function. It can e.g. also be put into the Initialize() method of the Workbench class (see InitGui.py). |
Replaced by #531 |
see forum topic:
http://forum.freecadweb.org/viewtopic.php?f=8&t=16773
especially starting from post:
http://forum.freecadweb.org/viewtopic.php?f=8&t=16773&start=10#p159031
cheers bernd
I have no glue what to do in the regard of all these new cool icon stuff. I just added one icon.