Sketcher: task tool settings widget #5389

PaddleStroke · 2022-01-17T17:51:09Z

This feature adds a widget to Task in sketcher.
This enables user to type dimensions of geometries and create constraints accordingly.
The goal is to speed up sketching.

Feature discussed here : https://forum.freecadweb.org/viewtopic.php?f=9&t=65279
Video showing the feature : https://youtu.be/K8oTQNpI8CQ

One thing to discuss : What key to use for polyline mode switch. 'M' can't be used anymore because it's typed in the spinbox. So I changed to shift. But shift may be in use by others?

Please let me know if you have any question/feedback.

(Solved conflict)

Also add seek third to oblong to select radius point.

Circle, arcs, lines, point, polygone implemented. Polyline need further work. Also ESC keypress doesn't work properly when task window has focus. This needs to be corrected (conflict solved)

Several bugs of tool settings fixed. Includes Oblong, arc and 3points arc. Keypressed still can't be forwarded to sketchhandler...

Support for polyline improved and mode key replaced by shift. Solved bugs on spinbox pre-selection of text. Also update the geometry directly after value entered (no need to move mouse).

davidosterberg · 2022-01-17T20:04:07Z

src/Mod/Sketcher/Gui/TaskSketcherTool.h

@@ -0,0 +1,111 @@
+/***************************************************************************
+ *   Copyright (c) 2009 Jürgen Riegel <juergen.riegel@web.de>              *


Your name. Jurgen has left the project. He does not need more files in his name.

He does not need more files in his name.

I don't disagree with the point but I think the tone could be perceived as a little irreverent.

That was not the intention. He is just not the author of this file. He probably authored the template this was based on. But the main contributor is Paddle so he should be mentioned. Also the year should probably be updated.

davidosterberg · 2022-01-17T20:08:54Z

src/Mod/Sketcher/Gui/TaskSketcherTool.h

+                  Gui::SelectionSingleton::MessageType Reason);
+    SketcherToolWidget* widget;
+
+//public Q_SLOTS:


No point in having commented out code here.

davidosterberg

Looks good. Some minor comments. The question of the shift key for the polyline tool is a bit tricky.

- fixed PR comments

PaddleStroke · 2022-01-18T06:10:53Z

Thanks.
I made the modifications mentioned and solved the over-constraint bug with perpendicular mode of polyline that can be seen in the video.

The last question is for polyline mode shortcut.
For shift : is there other shortcuts using it beside shift + RMB for rotation? If it's the only issue then we can try to catch the +RMB in the polyline tool and cancel the mode change of the tool if + RMB is done.
Beside we can use another key than shift. What about the F3-F12 keys? Or Screenlock or pause (though most laptop won't have those). Other key ideas?

PaddleStroke · 2022-01-19T21:25:25Z

It seems the shortcuts are currently being refactored. So it might be better to keep shift for now until the global shortcut refactoring is done.
Beside the only conflict is with rotating with shift + rmb which is currently not working properly in sketcher edit mode. So it's kind of niche issue and might be solved anyway by the refactoring.

freecadci · 2022-01-22T14:23:31Z

for feature branch PR_5389. Pipeline 454040201 was triggered at cbc579a. All CI branches and pipelines.

adrianinsaval · 2022-02-04T17:22:20Z

any particular reason for closing this one? :(

PaddleStroke · 2022-02-04T17:59:53Z

It's because I build constrain contextually on top of ToolSettings. And I made further improvement of toolsettings on that ConstrainContextuall branch.
So this branch was kind of obsolete. All should be merged in the other branch.

adrianinsaval · 2022-02-04T18:50:06Z

considering past statements from the maintainers, I think they would prefer to merge it separately as this feature is independent of the other but better to wait for what they have to say. I think abdullah is who usually reviews sketcher stuff but he's not around for now.

luzpaz · 2022-02-04T19:07:16Z

@abdullahtahiriyo has had IRL (work etc...) stuff going on. But he pops in here and there. Hopefully he can weigh-in on some of @PaddleStroke's work soon

PaddleStroke · 2022-02-04T19:55:43Z

considering past statements from the maintainers, I think they would prefer to merge it separately as this feature is independent of the other but better to wait for what they have to say. I think abdullah is who usually reviews sketcher stuff but he's not around for now.

Yes I know but I had to make lot of modification and fixes to toolsettings while developping constrain contextually. And I couldn't checkout of branches everytime I needed to make a small change (because it takes 1 hour to rebuild everytime). So I ended up making the changes to ToolSettings along the development of Constrain contextually. Which in the end was a lot.
And as Constrain Contextually builds on top of ToolSettings, it had to integrate that branch in the first place.

adrianinsaval · 2022-02-04T20:01:34Z

are you mixing stuff within the same commit? if you have separate commits for stuff only related to this widget it would be possible to cherry pick only those. You are developing on windows right? Is there really no equivalent to ccache on windows? That would be a shame, with ccache compilation should require just a few minutes if the difference isn't big.

PaddleStroke · 2022-02-04T20:06:54Z

I didn't paid attention to the commit's content unfortunately. With visual studio it builds only what you modified (so 1-2min for sketcher modif). But when I checkout of branches it rebuilds the whole thing. Making checkouts painful.

…

On Fri, Feb 4, 2022, 21:01 adrianinsaval ***@***.***> wrote: are you mixing stuff within the same commit? if you have separate commits for stuff only related to this widget it would be possible to cherry pick only those. You are developing on windows right? Is there really no equivalent to ccache on windows? That would be a shame, with ccache compilation should require just a few minutes if the difference isn't big. — Reply to this email directly, view it on GitHub <#5389 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEYO6MJDBAOPO7KIUZI2XNDUZQWCTANCNFSM5MFIQKFQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

abdullahtahiriyo · 2022-02-05T04:35:45Z

Ok, I will handle it with the other commit. It gets some time before learning how to use git effectively.

PaddleStroke added 5 commits January 15, 2022 16:06

Sketcher tool setting implementation. Only for rectangle tool for now.

c23a708

(Solved conflict)

Add sketcherTool settings support for oblong (round corner rectangle).

8b97dd0

Also add seek third to oblong to select radius point.

Sketch Tool Settings.

7368cdb

Circle, arcs, lines, point, polygone implemented. Polyline need further work. Also ESC keypress doesn't work properly when task window has focus. This needs to be corrected (conflict solved)

Oblong radius following mouse is now behaving properly.

5385c89

Several bugs of tool settings fixed. Includes Oblong, arc and 3points arc. Keypressed still can't be forwarded to sketchhandler...

Support for ellipse added.

6897bc7

Support for polyline improved and mode key replaced by shift. Solved bugs on spinbox pre-selection of text. Also update the geometry directly after value entered (no need to move mouse).

github-actions bot added the ✏️ Sketcher label Jan 17, 2022

davidosterberg reviewed Jan 17, 2022

View reviewed changes

davidosterberg suggested changes Jan 17, 2022

View reviewed changes

luzpaz changed the title ~~SKETCHER : task tool settings widget~~ Sketcher: task tool settings widget Jan 17, 2022

- fixed the over-constraint issue with polyline perpendicular modes.

54841d5

- fixed PR comments

PaddleStroke force-pushed the TaskToolWidget branch from 15f964b to 54841d5 Compare January 18, 2022 06:03

Merge branch 'FreeCAD:master' into TaskToolWidget

4227489

Merge branch 'master' into TaskToolWidget

ae08c4c

Merge branch 'master' into TaskToolWidget

cbc579a

PaddleStroke marked this pull request as draft February 4, 2022 14:28

PaddleStroke closed this Feb 4, 2022

luzpaz added WB Sketcher Related to the Sketcher Workbench and removed ✏️ Sketcher labels Feb 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sketcher: task tool settings widget #5389

Sketcher: task tool settings widget #5389

PaddleStroke commented Jan 17, 2022

davidosterberg Jan 17, 2022

luzpaz Jan 17, 2022

davidosterberg Jan 21, 2022

davidosterberg Jan 17, 2022

davidosterberg left a comment

PaddleStroke commented Jan 18, 2022

PaddleStroke commented Jan 19, 2022

freecadci commented Jan 22, 2022

adrianinsaval commented Feb 4, 2022

PaddleStroke commented Feb 4, 2022

adrianinsaval commented Feb 4, 2022

luzpaz commented Feb 4, 2022 •

edited

PaddleStroke commented Feb 4, 2022

adrianinsaval commented Feb 4, 2022

PaddleStroke commented Feb 4, 2022 via email

abdullahtahiriyo commented Feb 5, 2022

		@@ -0,0 +1,111 @@
		/***************************************************************************
		* Copyright (c) 2009 Jürgen Riegel <juergen.riegel@web.de> *

Sketcher: task tool settings widget #5389

Sketcher: task tool settings widget #5389

Conversation

PaddleStroke commented Jan 17, 2022

davidosterberg Jan 17, 2022

Choose a reason for hiding this comment

luzpaz Jan 17, 2022

Choose a reason for hiding this comment

davidosterberg Jan 21, 2022

Choose a reason for hiding this comment

davidosterberg Jan 17, 2022

Choose a reason for hiding this comment

davidosterberg left a comment

Choose a reason for hiding this comment

PaddleStroke commented Jan 18, 2022

PaddleStroke commented Jan 19, 2022

freecadci commented Jan 22, 2022

adrianinsaval commented Feb 4, 2022

PaddleStroke commented Feb 4, 2022

adrianinsaval commented Feb 4, 2022

luzpaz commented Feb 4, 2022 • edited

PaddleStroke commented Feb 4, 2022

adrianinsaval commented Feb 4, 2022

PaddleStroke commented Feb 4, 2022 via email

abdullahtahiriyo commented Feb 5, 2022

luzpaz commented Feb 4, 2022 •

edited