New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TechDraw: Fix texts in TaskSelectLineAttributes.ui #5486
TechDraw: Fix texts in TaskSelectLineAttributes.ui #5486
Conversation
Fix text regression.
@@ -120,7 +120,7 @@ | |||
<item row="2" column="0"> | |||
<widget class="QRadioButton" name="rbMiddle"> | |||
<property name="text"> | |||
<string>middle 0,35</string> | |||
<string>Middle 0,35</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I prefer European commas, then is it meant to be so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fixed by using the line groups we have since a while in TD. @WandererFan , could you please have a look when you find time?
However, this PR is just to fix a regression -> merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What am I looking for? Using the weights from the LineGroup file instead of hard coded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this would be my proposal. So instead of the radio buttons, a combobox to select the line group like we have in the TD preferences.
By the way, what menu do I have to use to see the TaskSelectLineAttributes dialog?
This one, I believe
https://wiki.freecadweb.org/TechDraw_ExtensionSelectLineAttributes
…On Thu, Feb 3, 2022 at 9:48 PM Uwe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Mod/TechDraw/Gui/TaskSelectLineAttributes.ui
<#5486 (comment)>:
> @@ -120,7 +120,7 @@
<item row="2" column="0">
<widget class="QRadioButton" name="rbMiddle">
<property name="text">
- <string>middle 0,35</string>
+ <string>Middle 0,35</string>
Yes, this would be my proposal. So instead of the radio buttons, a
combobox to select the line group like we have in the TD preferences.
By the way, what menu do I have to use to see the TaskSelectLineAttributes
dialog?
—
Reply to this email directly, view it on GitHub
<#5486 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3LYWKBAOKICWAFVT5V6RTUZM5BFANCNFSM5NMVPOUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks. Yes, I think using the LineGroup is the right solution for this dialog. |
Fix text regression.
Forum topic:
https://forum.freecadweb.org/viewtopic.php?f=35&t=65727
App
,Base
,Gui
or one of theMod
subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master
./bin/FreeCAD --run-test 0
Fixes typo in Draft Move command text
Draft: Fixed typos
issue #<id>
orfixes #<id>
where<id>
is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex:Draft: fix typos - fixes #0004805