Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TechDraw: Fix texts in TaskSelectLineAttributes.ui #5486

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Feb 2, 2022

Fix text regression.

Forum topic:
https://forum.freecadweb.org/viewtopic.php?f=35&t=65727

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

@github-actions github-actions bot added the WB TechDraw Related to the TechDraw Workbench label Feb 2, 2022
@freecadci
Copy link

pipeline status for feature branch PR_5486. Pipeline 462153095 was triggered at 09d78ea. All CI branches and pipelines.

@@ -120,7 +120,7 @@
<item row="2" column="0">
<widget class="QRadioButton" name="rbMiddle">
<property name="text">
<string>middle 0,35</string>
<string>Middle 0,35</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I prefer European commas, then is it meant to be so?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed by using the line groups we have since a while in TD. @WandererFan , could you please have a look when you find time?

However, this PR is just to fix a regression -> merging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What am I looking for? Using the weights from the LineGroup file instead of hard coded?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this would be my proposal. So instead of the radio buttons, a combobox to select the line group like we have in the TD preferences.

By the way, what menu do I have to use to see the TaskSelectLineAttributes dialog?

@donovaly donovaly merged commit bc49fed into FreeCAD:master Feb 3, 2022
@Roy-043 Roy-043 deleted the TechDraw-Fix-texts-in-TaskSelectLineAttributes.ui branch February 4, 2022 14:11
@WandererFan
Copy link
Contributor

WandererFan commented Feb 4, 2022 via email

@donovaly
Copy link
Member

donovaly commented Feb 5, 2022

This one, I believe https://wiki.freecadweb.org/TechDraw_ExtensionSelectLineAttributes

Thanks.

Yes, I think using the LineGroup is the right solution for this dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB TechDraw Related to the TechDraw Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants