You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "-a" commit is strange and probably invalid. The commit title is definitely invalid :-)
Please give those 2 "Glass Materials" different titles to describe what's inside. 2 of them should be merged together. I'm fairly sure we don't use brackets for units. That merge commit should not be in the pull request. No spaces in the field names, so "Compressive Strength" --> "CompressiveStrength". Density in kg/m^3 please. Price should be SpecificPrice. Please see src/Mod/Material/StandardMaterial/Tools/headers for supported headers. If you need more please discuss on the forum. (What is Softening T ?). Please get yourself familiar with src/Mod/Material/StandardMaterial/TEMPLATE.FCMat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two new materials in list. Corrected a little spell mistake in Readme.txt file.