Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import]Fix #6461 MEASUREMENT/INSUNITS #6470

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

WandererFan
Copy link
Contributor

This PR fixes issue #6461 where mm to inch calculation was performed twice for certain values of MEASUREMENT and INSUNITS variables in the imported DXF file.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@luzpaz luzpaz linked an issue Feb 27, 2022 that may be closed by this pull request
2 tasks
@freecadci
Copy link

pipeline status for feature branch PR_6470. Pipeline 480439321 was triggered at 1102a55. All CI branches and pipelines.

@WandererFan WandererFan merged commit 2ff5e1a into FreeCAD:master Feb 27, 2022
@WandererFan WandererFan deleted the dxfInch branch February 27, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] C++ DXF importer: Wrong scale factor for inches
2 participants