Use python3 to run MakeMacBundleRelocatable.py

[ageeye]

Python 2.7 was removed from macOS in update Monterey 12.3.
Feature request in the forum upgrade MakeMacBundleRelocatable.py to work with python 3.

Closes #6773

[ageeye]

@ipatch
@looooo

Please test it.

[freecadci]

for feature branch PR_6784. Pipeline 523031767 was triggered at c39b635. All CI branches and pipelines.

[ipatch]

awesome i'll take a look at this in a few.

[ipatch]

okay finally got around to testing this PR locally on my vm mojave build box, and im seeing the below error running make install

-- INFO: Analyzing bundle dependencies...
Traceback (most recent call last):
  File "/opt/code/freecad-git/freecad-src/src/Tools/MakeMacBundleRelocatable.py", line 391, in <module>
    main()
  File "/opt/code/freecad-git/freecad-src/src/Tools/MakeMacBundleRelocatable.py", line 374, in main
    build_deps_graph(graph, bundle_path, dir_filter, search_paths)
  File "/opt/code/freecad-git/freecad-src/src/Tools/MakeMacBundleRelocatable.py", line 229, in build_deps_graph
    for k in visited.keys():
RuntimeError: dictionary changed size during iteration

[ageeye]

Whatever with python3.10.2 method keys work fine. I think you used python3.9.7. I replace keys with list. See the new commit. Please test it again.

// edit:

The views returned by dict.keys(), dict.values() and dict.items() ...

[freecadci]

for feature branch PR_6784. Pipeline 523252207 was triggered at 3c91839. All CI branches and pipelines.

[freecadci]

for feature branch PR_6784. Pipeline 523256367 was triggered at 2934820. All CI branches and pipelines.

[ipatch]

rebuilding now with your updates, will let you know in a few.

[ageeye]

rebuilding now with your updates, will let you know in a few.

Have you had a chance to check it?

[ipatch]

rebuilding now with your updates, will let you know in a few.

Have you had a chance to check it?

working on it now. hopefully ill have something of meaning to share before COB CST 🤞

working with broken wrist so im down to one hand for typing 🤕

[ageeye]

Best wishes for a speedy recovery. No sweat!

[ipatch]

i'm pretty sure we should be good to go on this 👍 there was issue where this only worked with python ≥ 3.10 but has since been amended to work with python ≥ 3.9. 👍

ive been testing this PR on my movaje build box and with this PR python3 provided by homebrew is able to produce a FreeCAD.app bundle. so at this point i feel confident this is working.

and i just got access to an m1 box again the other so will test again on m1 shortly. (hopefully later today).

---

something non related however, is when the python script is Updating dynamic loader paths... it sometimes produces an app bundle that will halt on launch ie. double clicking the FreeCAD.app starts the launch process then the app never finishes launching and then macos opens with a crash report. i can only speculate why certain app bundles do this and others don't at this time unfortunately. i have found a very crude way to know that is the part where the script is Updating dynamic loader paths... but much more than that i don't know why the app bundle is failing to launch in certain instances. once again this is not related to this PR.

---

but once again, i consider this working, and should be merged ✅

[ageeye]

Thanks for the feedback.

---

If the App do not start, please start it with lldb:

lldb FreeCAD.app/Contents/MacOS/freecad

r

The prime suspect is shiboken. In the MacAppBundle CMake copy some libs like numpy to the bundle. But Homebrew do not allow keg_only formula to write the .pth in the lib path. So, the script do not find the dependencies.

[ipatch]

@ageeye

thanks for sharing that. 🙏 next time i run into an app bundle that won't launch ill give this a go.

[ageeye]

In the forum looooo wrote, that conda do not use this script. So for my part it is possible to merge this PR.

[freecadci]

for feature branch PR_6784. Pipeline 528781363 was triggered at c79b38a. All CI branches and pipelines.

[luzpaz]

@donovaly ping