Path: Fix PointProjectionFailed

[younghang]

fix the PointProjectionFailed exception when split edge in wrebaseWire().

---

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

• Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
• In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
• Your branch is rebased on latest master git pull --rebase upstream master
• All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
• All commit messages are well-written ex: Fixes typo in Draft Move command text
• Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
• Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.

---

[freecadci]

for feature branch PR_6886. Pipeline 539544670 was triggered at 7630ee0. All CI branches and pipelines.

[luzpaz]

Is there a forum thread associated with this PR?

[luzpaz]

Looks like it's failing the CI, but I don't understand why.
@younghang please run:

git commit --amend -m "Path: fix the PointProjectionFailed exception when split edge in wrebaseWire()" -m "<reference a forum discussion here>"`

[younghang]

Is there a forum thread associated with this PR?

No, I have searched this in the forum. I found the reason for the PointProjectionFailed, that is when

 gp_Pnt pprev(BRep_Tool::Pnt(xp.CurrentVertex()));

is called, there is a tiny difference between pprev and vertex around 0.0000001. which raise the PointProjectionFail exception in

mkEdge1.Init(curve, myBestPt, pprev);

.

Looks like it's failing the CI, but I don't understand why.

@luzpaz I made a mistake the vairable name is wrong. I have made another commit.

[freecadci]

for feature branch PR_6886. Pipeline 539716433 was triggered at 07d7ced. All CI branches and pipelines.

[luzpaz]

CC @sliptonic please review when you get a chance..thanks!

[freecadci]

for feature branch PR_6886. Pipeline 540628320 was triggered at 5ae3a08. All CI branches and pipelines.

[realthunder]

@younghang I suggest to try this projection on curve only if it fails to make either edges.

[freecadci]

for feature branch PR_6886. Pipeline 541638197 was triggered at a21a5a2. All CI branches and pipelines.

[freecadci]

for feature branch PR_6886. Pipeline 541638944 was triggered at 18120f8. All CI branches and pipelines.

[younghang]

curve only if it fails to make either edges.

@realthunder The split operation only executes once when the StartPoint is set, and I think the split point should on the edge though not all edges fail in current operation.

Another bug I found in this rebaseWire() is when the StartPoint is set on some edge by force, the closed wire will be broken some edges are missing.
I use

       if (edge.Orientation() != myBestWire->wire.Orientation())
       {
            mkEdge1.Init(curve, myBestPt, pprev);
            mkEdge2.Init(curve, pt, myBestPt);
       }

instead of

      if(reversed) {
           mkEdge1.Init(curve, myBestPt, pprev);
           mkEdge2.Init(curve, pt, myBestPt);
      }

and it seems to work in my project.

[luzpaz]

@younghang can you post to the Path subforum announcing this PR and x-post this URL back to this ticket so we can track it?)

[younghang]

@younghang can you post to the Path subforum announcing this PR and x-post this URL back to this ticket so we can track it?)

@luzpaz Okay. I have post it here: https://forum.freecadweb.org/viewtopic.php?f=15&t=68956

[donovaly]

What is the status of this PR?

@sliptonic , can you please have a look?

[donovaly]

@younghang , many thanks for the fix!

In future you only need to check that it compiles also when precompiled headers.
I fixed this now by adding the missing include to Precompiled.h: d13ecc1efa177be